KEMBAR78
Add type alias for `Result` by mgrachev · Pull Request #445 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Add type alias for Result #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2021
Merged

Add type alias for Result #445

merged 1 commit into from
Oct 30, 2021

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Oct 30, 2021 •
edited
Loading

A little refactoring of the code.
Moved a repetitive Box <dyn Error> into a separate Result type.

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev mgrachev requested a review from a team October 30, 2021 13:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021 •
edited
Loading

Codecov Report

Merging #445 (55537cc) into master (0e988d7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files          40       40              
  Lines        2766     2764       -2     
==========================================
- Hits         2736     2734       -2     
  Misses         30       30
Impacted Files Coverage Δ
src/fs_utils.rs 95.45% <100.00%> (ø)
src/lib.rs 97.84% <100.00%> (-0.04%) ⬇️
src/main.rs 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e988d7...55537cc. Read the comment docs.

@github-actions
Copy link

Benchmark for 554eb9d

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 70.2±8.96µs 70.7±4.84µs -0.71%
dotenv_linter compare 59.3±4.58µs 57.6±4.41µs +2.95%
dotenv_linter fix 194.2±43.44µs 211.3±64.28µs -8.09%
dotenv_linter fix with backup 288.1±135.73µs 296.3±119.26µs -2.77%

@github-actions
Copy link

Benchmark for 8fbd045

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 74.7±3.47µs 73.6±4.07µs +1.49%
dotenv_linter compare 64.5±4.20µs 65.4±4.05µs -1.38%
dotenv_linter fix 217.4±55.71µs 214.2±16.81µs +1.49%
dotenv_linter fix with backup 273.2±124.58µs 318.1±170.76µs -14.12%

@mgrachev
refactor: add type alias for Result
55537cc 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@github-actions
Copy link

Benchmark for 43508c9

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 66.4±1.66µs 63.0±2.77µs +5.40%
dotenv_linter compare 54.1±0.91µs 52.0±1.84µs +4.04%
dotenv_linter fix 171.3±105.37µs 171.1±90.45µs +0.12%
dotenv_linter fix with backup 204.3±76.78µs 210.7±101.58µs -3.04%

@DDtKey DDtKey added hacktoberfest-accepted Hacktoberfest accepted improvement Various Improvements labels Oct 30, 2021
@mgrachev mgrachev merged commit 499be25 into master Oct 30, 2021
@mgrachev mgrachev deleted the type-alias-result branch October 30, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Hacktoberfest accepted improvement Various Improvements

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @codecov-commenter @DDtKey