KEMBAR78
Tidy up imports by mgrachev · Pull Request #446 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Tidy up imports #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2021
Merged

Tidy up imports #446

merged 1 commit into from
Oct 30, 2021

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Oct 30, 2021 •
edited
Loading

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev mgrachev requested a review from a team October 30, 2021 15:56
@mgrachev mgrachev changed the title refactor: tidy up imports Tidy up imports Oct 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021 •
edited
Loading

Codecov Report

Merging #446 (baf93c2) into master (499be25) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          40       40           
  Lines        2764     2764           
=======================================
  Hits         2734     2734           
  Misses         30       30
Impacted Files Coverage Δ
src/checks.rs 100.00% <ø> (ø)
src/checks/duplicated_key.rs 100.00% <ø> (ø)
src/checks/ending_blank_line.rs 100.00% <ø> (ø)
src/checks/key_without_value.rs 100.00% <ø> (ø)
src/checks/leading_character.rs 100.00% <ø> (ø)
src/checks/lowercase_key.rs 100.00% <ø> (ø)
src/checks/space_character.rs 100.00% <ø> (ø)
src/checks/trailing_whitespace.rs 100.00% <ø> (ø)
src/common.rs 100.00% <ø> (ø)
src/common/compare.rs 100.00% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499be25...baf93c2. Read the comment docs.

@github-actions
Copy link

Benchmark for 0cb697c

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 73.2±3.16µs 68.5±2.62µs +6.86%
dotenv_linter compare 56.4±2.09µs 59.0±1.89µs -4.41%
dotenv_linter fix 258.1±302.69µs 196.9±15.60µs +31.08%
dotenv_linter fix with backup 295.9±228.63µs 285.8±110.50µs +3.53%

@github-actions
Copy link

Benchmark for 529729c

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 52.9±3.92µs 51.8±2.43µs +2.12%
dotenv_linter compare 43.3±3.35µs 43.0±1.64µs +0.70%
dotenv_linter fix 171.0±74.08µs 171.0±42.19µs 0.00%
dotenv_linter fix with backup 221.6±98.34µs 216.4±83.93µs +2.40%

DDtKey
DDtKey previously approved these changes Oct 30, 2021
View reviewed changes
@DDtKey DDtKey added hacktoberfest-accepted Hacktoberfest accepted improvement Various Improvements labels Oct 30, 2021
@mgrachev
refactor: tidy up imports
baf93c2 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@github-actions
Copy link

Benchmark for d4f3d77

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 66.8±1.50µs 65.8±2.32µs +1.52%
dotenv_linter compare 54.6±0.64µs 53.5±1.30µs +2.06%
dotenv_linter fix 189.2±108.18µs 179.0±137.23µs +5.70%
dotenv_linter fix with backup 219.2±93.96µs 218.5±116.16µs +0.32%

@mgrachev mgrachev merged commit cf491f7 into master Oct 30, 2021
@mgrachev mgrachev deleted the refactor-link-kind branch October 30, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey left review comments

Assignees

No one assigned

Labels

hacktoberfest-accepted Hacktoberfest accepted improvement Various Improvements

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @codecov-commenter @DDtKey