KEMBAR78
Replace `LineEntry` with line number in `Warning` by mgrachev · Pull Request #447 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Replace LineEntry with line number in Warning #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2021
Merged

Replace LineEntry with line number in Warning #447

merged 1 commit into from
Oct 30, 2021

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Oct 30, 2021 •
edited
Loading

Close #410

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev mgrachev requested a review from a team October 30, 2021 18:00
@mgrachev mgrachev changed the title refactor: replace LineEntry with line number in Warning Replace LineEntry with line number in Warning Oct 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021 •
edited
Loading

Codecov Report

Merging #447 (af60e24) into master (cf491f7) will decrease coverage by 0.02%.
The diff coverage is 99.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   98.91%   98.89%   -0.03%     
==========================================
  Files          40       40              
  Lines        2764     2619     -145     
==========================================
- Hits         2734     2590     -144     
+ Misses         30       29       -1
Impacted Files Coverage Δ
src/fixes.rs 92.56% <92.30%> (-0.10%) ⬇️
src/checks.rs 100.00% <100.00%> (ø)
src/checks/duplicated_key.rs 100.00% <100.00%> (ø)
src/checks/ending_blank_line.rs 100.00% <100.00%> (ø)
src/checks/extra_blank_line.rs 100.00% <100.00%> (ø)
src/checks/incorrect_delimiter.rs 100.00% <100.00%> (ø)
src/checks/key_without_value.rs 100.00% <100.00%> (ø)
src/checks/leading_character.rs 100.00% <100.00%> (ø)
src/checks/lowercase_key.rs 100.00% <100.00%> (ø)
src/checks/quote_character.rs 100.00% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf491f7...af60e24. Read the comment docs.

@github-actions
Copy link

Benchmark for fca39e6

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 72.8±2.73µs 72.2±2.46µs +0.83%
dotenv_linter compare 57.4±3.20µs 58.2±3.31µs -1.37%
dotenv_linter fix 209.5±17.00µs 204.5±16.11µs +2.44%
dotenv_linter fix with backup 285.6±150.07µs 293.5±116.76µs -2.69%

DDtKey
DDtKey previously approved these changes Oct 30, 2021
View reviewed changes
@DDtKey DDtKey added hacktoberfest-accepted Hacktoberfest accepted improvement Various Improvements labels Oct 30, 2021
@mgrachev
refactor: replace LineEntry with line number in Warning
af60e24 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev requested a review from DDtKey October 30, 2021 18:32
@github-actions
Copy link

Benchmark for e11de3c

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 75.0±5.05µs 74.2±5.19µs +1.08%
dotenv_linter compare 59.3±3.04µs 59.1±2.05µs +0.34%
dotenv_linter fix 204.9±53.43µs 207.3±17.24µs -1.16%
dotenv_linter fix with backup 286.7±141.57µs 271.7±106.05µs +5.52%

@github-actions
Copy link

Benchmark for 64decf6

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 71.3±2.22µs 73.4±5.30µs -2.86%
dotenv_linter compare 58.9±3.37µs 58.2±3.12µs +1.20%
dotenv_linter fix 221.2±133.77µs 195.8±69.52µs +12.97%
dotenv_linter fix with backup 290.1±190.51µs 279.3±243.15µs +3.87%

@mgrachev mgrachev merged commit eef34cb into master Oct 30, 2021
@mgrachev mgrachev deleted the refac-warning branch October 30, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey Awaiting requested review from DDtKey

Assignees

No one assigned

Labels

hacktoberfest-accepted Hacktoberfest accepted improvement Various Improvements

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use Rc for Warning to reduce memory consumption

3 participants

@mgrachev @codecov-commenter @DDtKey