KEMBAR78
Get rid of `Rc<FileEntry>` in `LineEntry` by mgrachev · Pull Request #448 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Get rid of Rc<FileEntry> in LineEntry #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2021
Merged

Get rid of Rc<FileEntry> in LineEntry #448

merged 1 commit into from
Oct 30, 2021

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Oct 30, 2021 •
edited
Loading

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev
refactor: get rid of Rc<FileEntry> in LineEntry
75c7b36 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev requested a review from a team October 30, 2021 19:12
@codecov-commenter
Copy link

Codecov Report

Merging #448 (75c7b36) into master (eef34cb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   98.89%   98.88%   -0.01%     
==========================================
  Files          40       40              
  Lines        2619     2611       -8     
==========================================
- Hits         2590     2582       -8     
  Misses         29       29
Impacted Files Coverage Δ
src/checks/ending_blank_line.rs 100.00% <100.00%> (ø)
src/common.rs 100.00% <100.00%> (ø)
src/common/line_entry.rs 100.00% <100.00%> (ø)
src/fixes/ending_blank_line.rs 100.00% <100.00%> (ø)
src/lib.rs 97.87% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef34cb...75c7b36. Read the comment docs.

@github-actions
Copy link

Benchmark for 27ff912

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 64.6±3.38µs 68.2±2.22µs -5.28%
dotenv_linter compare 49.7±2.75µs 58.8±2.64µs -15.48%
dotenv_linter fix 198.3±64.06µs 178.4±52.28µs +11.15%
dotenv_linter fix with backup 246.0±149.59µs 253.9±186.95µs -3.11%

@DDtKey DDtKey added improvement Various Improvements hacktoberfest-accepted Hacktoberfest accepted labels Oct 30, 2021
@mgrachev mgrachev merged commit 217a066 into master Oct 30, 2021
@mgrachev mgrachev deleted the refactoring-line-entry branch October 30, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Hacktoberfest accepted improvement Various Improvements

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @codecov-commenter @DDtKey