feat: add support for multi-line single-quoted values #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDtKey
force-pushed
the
multiline-value
branch
from
6e0b9ee to
4af78bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
- Coverage 98.88% 98.86% -0.02%
==========================================
Files 40 40
Lines 2611 2654 +43
==========================================
+ Hits 2582 2624 +42
- Misses 29 30 +1
Continue to review full report at Codecov.
|
DDtKey
changed the title
Benchmark for 116c5e6Click to view benchmark
|
DDtKey
changed the title
DDtKey
commented
Nov 24, 2021
mgrachev
reviewed
Nov 26, 2021
Benchmark for 6bd345bClick to view benchmark
|
mgrachev
approved these changes
Nov 28, 2021
|
@DDtKey Thanks a lot 👍 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for real multi-line value support #442.
It's temporary ugly solution, but it works.Currently, I have added support of real multiline single-quoted values.
This implementation allows us to perform all checks on such values, since they are transformed into one
LineEntry.@dotenv-linter/core I suggest to consider this PR and, if approved, add support of multiline double-quoted values in another pull request (if needed at all) 🤔
Partially closes #442
✔ Checklist: