KEMBAR78
Fix clippy warnings by mgrachev · Pull Request #452 · dotenv-linter/dotenv-linter · GitHub
Skip to content

Fix clippy warnings #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix clippy warnings #452

merged 1 commit into from
Dec 8, 2021

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Dec 6, 2021 •
edited
Loading

✔ Checklist:

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Benchmark for c0b80ed

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 51.5±0.29µs 52.1±0.14µs -1.15%
dotenv_linter compare 44.3±0.29µs 44.4±1.00µs -0.23%
dotenv_linter fix 140.8±137.24µs 151.3±145.15µs -6.94%
dotenv_linter fix with backup 176.9±108.28µs 186.1±144.90µs -4.94%

@mgrachev mgrachev force-pushed the fix-clippy-warnings branch from 4ed9a29 to bbcfda1 Compare December 6, 2021 13:27
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Benchmark for 2c0c64f

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 55.3±2.18µs 56.0±2.65µs -1.25%
dotenv_linter compare 46.6±1.37µs 48.0±3.11µs -2.92%
dotenv_linter fix 173.7±115.23µs 165.3±75.83µs +5.08%
dotenv_linter fix with backup 234.1±99.33µs 235.1±145.80µs -0.43%

@mgrachev mgrachev requested a review from DDtKey December 8, 2021 09:20
DDtKey
DDtKey reviewed Dec 8, 2021
View reviewed changes
@mgrachev
refactor: use derive (default) instead of impl
8d58a75 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev force-pushed the fix-clippy-warnings branch from bbcfda1 to 8d58a75 Compare December 8, 2021 14:15
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Benchmark for 5af9083

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 55.3±8.00µs 61.8±4.94µs -10.52%
dotenv_linter compare 47.9±4.93µs 53.0±3.80µs -9.62%
dotenv_linter fix 195.0±75.27µs 193.7±54.46µs +0.67%
dotenv_linter fix with backup 256.2±136.36µs 274.2±145.04µs -6.56%

@mgrachev mgrachev merged commit 8c7eab3 into master Dec 8, 2021
@mgrachev mgrachev deleted the fix-clippy-warnings branch December 8, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgrachev @DDtKey