KEMBAR78
fix(#461): fail with one quote-char in line by DDtKey · Pull Request #462 · dotenv-linter/dotenv-linter · GitHub
Skip to content

fix(#461): fail with one quote-char in line #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2022
Merged

fix(#461): fail with one quote-char in line #462

merged 3 commits into from
Jan 9, 2022

Conversation

@DDtKey
Copy link
Member

@DDtKey DDtKey commented Jan 9, 2022 •
edited
Loading

It pretty simple bug. I've added test.
Closes #461

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022 •
edited
Loading

Codecov Report

Merging #462 (3108386) into master (456dd8b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   98.88%   98.88%   -0.01%     
==========================================
  Files          41       41              
  Lines        2701     2699       -2     
==========================================
- Hits         2671     2669       -2     
  Misses         30       30
Impacted Files Coverage Δ
src/common/line_entry.rs 100.00% <100.00%> (ø)
src/common/quote_type.rs 100.00% <100.00%> (ø)
src/lib.rs 98.50% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456dd8b...3108386. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 9, 2022

Benchmark for fbd11b5

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 60.3±2.76µs 61.2±3.11µs -1.47%
dotenv_linter compare 45.6±2.87µs 43.7±1.81µs +4.35%
dotenv_linter fix 155.3±93.86µs 166.9±90.94µs -6.95%
dotenv_linter fix with backup 198.2±101.75µs 200.2±139.74µs -1.00%

@DDtKey DDtKey requested a review from mgrachev January 9, 2022 12:33
@github-actions
Copy link

github-actions bot commented Jan 9, 2022

Benchmark for dd75a66

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 67.3±4.28µs 73.3±4.48µs -8.19%
dotenv_linter compare 50.6±3.18µs 51.2±2.65µs -1.17%
dotenv_linter fix 206.1±140.92µs 190.1±67.98µs +8.42%
dotenv_linter fix with backup 256.8±163.13µs 251.4±106.82µs +2.15%

@github-actions
Copy link

github-actions bot commented Jan 9, 2022

Benchmark for 1eebc43

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 72.0±0.16µs 72.1±2.26µs -0.14%
dotenv_linter compare 52.5±0.72µs 52.6±0.19µs -0.19%
dotenv_linter fix 190.4±194.15µs 160.9±109.46µs +18.33%
dotenv_linter fix with backup 222.2±144.02µs 204.0±74.51µs +8.92%

@mgrachev mgrachev merged commit 994b817 into master Jan 9, 2022
@mgrachev mgrachev deleted the fix-461 branch January 9, 2022 12:46
@mgrachev
Copy link
Member

mgrachev commented Jan 9, 2022

Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Falls on checking multi-line values

3 participants

@DDtKey @codecov-commenter @mgrachev