KEMBAR78
fix: release by mgrachev · Pull Request #465 · dotenv-linter/dotenv-linter · GitHub
Skip to content

fix: release #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

fix: release #465

merged 1 commit into from
Jan 24, 2022

Conversation

@mgrachev
Copy link
Member

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022 •
edited
Loading

Codecov Report

Merging #465 (d500262) into master (df02210) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d500262 differs from pull request most recent head bf539f9. Consider uploading reports for the commit bf539f9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   98.88%   98.88%   -0.01%     
==========================================
  Files          41       41              
  Lines        2698     2697       -1     
==========================================
- Hits         2668     2667       -1     
  Misses         30       30
Impacted Files Coverage Δ
src/common/compare.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68f274...bf539f9. Read the comment docs.

@github-actions
Copy link

Benchmark for 0df693a

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 66.0±0.28µs 66.3±0.23µs -0.45%
dotenv_linter compare 48.2±0.34µs 48.7±1.16µs -1.03%
dotenv_linter fix 155.5±88.98µs 142.9±83.96µs +8.82%
dotenv_linter fix with backup 202.6±79.28µs 215.5±96.70µs -5.99%

@github-actions
Copy link

Benchmark for 6238ecd

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 65.5±0.83µs 65.1±1.42µs +0.61%
dotenv_linter compare 47.7±0.45µs 48.1±1.20µs -0.83%
dotenv_linter fix 178.0±173.64µs 165.4±198.27µs +7.62%
dotenv_linter fix with backup 202.0±135.20µs 191.7±76.83µs +5.37%

@mgrachev mgrachev force-pushed the fix-release branch 2 times, most recently from a48118b to d500262 Compare January 24, 2022 18:27
@github-actions
Copy link

Benchmark for 8617b58

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 57.9±0.18µs 57.9±0.84µs 0.00%
dotenv_linter compare 42.3±0.22µs 42.3±0.30µs 0.00%
dotenv_linter fix 185.6±230.32µs 141.9±87.97µs +30.80%
dotenv_linter fix with backup 190.0±124.44µs 266.9±446.71µs -28.81%

@github-actions
Copy link

Benchmark for 32b7778

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 69.6±3.95µs 70.1±4.87µs -0.71%
dotenv_linter compare 49.2±3.13µs 47.3±2.52µs +4.02%
dotenv_linter fix 181.1±66.22µs 186.9±75.94µs -3.10%
dotenv_linter fix with backup 254.2±119.50µs 263.0±111.66µs -3.35%

@github-actions
Copy link

Benchmark for 1a3201e

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 62.2±4.00µs 68.4±5.84µs -9.06%
dotenv_linter compare 48.1±2.52µs 49.4±3.14µs -2.63%
dotenv_linter fix 187.1±108.10µs 170.8±27.04µs +9.54%
dotenv_linter fix with backup 243.5±108.01µs 234.0±71.58µs +4.06%

DDtKey
DDtKey reviewed Jan 24, 2022
View reviewed changes
@mgrachev
fix: release
bf539f9 
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@github-actions
Copy link

Benchmark for bef1503

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 57.7±0.97µs 58.3±0.49µs -1.03%
dotenv_linter compare 42.1±0.18µs 41.8±0.25µs +0.72%
dotenv_linter fix 139.5±75.39µs 132.0±37.99µs +5.68%
dotenv_linter fix with backup 165.5±43.27µs 215.5±218.15µs -23.20%

@mgrachev mgrachev merged commit 1c86447 into master Jan 24, 2022
@mgrachev mgrachev deleted the fix-release branch January 24, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgrachev @codecov-commenter @DDtKey