KEMBAR78
ci: fix release builds by mgrachev · Pull Request #531 · dotenv-linter/dotenv-linter · GitHub
Skip to content

ci: fix release builds #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2022
Merged

ci: fix release builds #531

merged 2 commits into from
Jul 7, 2022

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Jul 6, 2022 •
edited
Loading

Fix: #466, #467

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev mgrachev linked an issue Jul 6, 2022 that may be closed by this pull request
Fix aarch64-pc-windows-msvc build #467
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022 •
edited
Loading

Codecov Report

Merging #531 (ea4147e) into master (4fba64b) will not change coverage.
The diff coverage is n/a.

❗ Current head ea4147e differs from pull request most recent head 2a6374a. Consider uploading reports for the commit 2a6374a to get more accurate results

@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files          43       43           
  Lines        2759     2759           
=======================================
  Hits         2730     2730           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fba64b...2a6374a. Read the comment docs.

@mgrachev mgrachev force-pushed the fix-release-builds branch from 7bd0c67 to 8bf4a89 Compare July 6, 2022 13:39
@mgrachev mgrachev requested a review from a team July 6, 2022 13:40
DDtKey
DDtKey previously approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Have you tested it? I mean on GH in the "not-release" mode in the PR?

@mgrachev
Copy link
Member Author

mgrachev commented Jul 7, 2022 •
edited
Loading

Have you tested it? I mean on GH in the "not-release" mode in the PR?

Sure 🙂
https://github.com/dotenv-linter/dotenv-linter/actions/runs/2622992120

@mgrachev
ci: fix release builds
2a6374a 
* `aarch64-unknown-linux-musl`
* `aarch64-pc-windows-msvc`

Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev mgrachev force-pushed the fix-release-builds branch from ea4147e to 2a6374a Compare July 7, 2022 12:28
@mgrachev mgrachev merged commit 3fd096e into master Jul 7, 2022
@mgrachev mgrachev deleted the fix-release-builds branch July 7, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix aarch64-pc-windows-msvc build Fix aarch64-unknown-linux-musl build

3 participants

@mgrachev @codecov-commenter @DDtKey