KEMBAR78
feat: add "No difference found" message on successful compare by jklott · Pull Request #648 · dotenv-linter/dotenv-linter · GitHub
Skip to content

feat: add "No difference found" message on successful compare #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2023
Merged

feat: add "No difference found" message on successful compare #648

merged 3 commits into from
Apr 3, 2023

Conversation

jklott
Copy link
Contributor

@jklott jklott commented Mar 16, 2023

This addresses Issue: #647

When two files are compared and no difference is found, the program prints

Comparing file1...
Comparing file2...

This then ends and goes back to the command line. My PR will change the functionality to show

Comparing file1...
Comparing file2...
No difference found

This will add some clarity on the compare command that no difference was found and no error caused the program to finish prematurely.

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

jklott added 3 commits March 16, 2023 08:59
@jklott
feat: add "No difference found" message on compare
34aad31 
Add "No difference found" message when comparing two files which have no difference.
@jklott
fix: run cargo fmt
553f354
@jklott
fix: use is_empty, not len==0
355324e 
For better clarify method should be .is_empty() and not .len()==0
@codecov-commenter
Copy link

Codecov Report

Merging #648 (553f354) into master (2f47ed1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 553f354 differs from pull request most recent head 355324e. Consider uploading reports for the commit 355324e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   99.16%   99.17%           
=======================================
  Files          46       46           
  Lines        2765     2772    +7     
=======================================
+ Hits         2742     2749    +7     
  Misses         23       23
Impacted Files Coverage Δ
dotenv-linter/src/common/output/compare.rs 100.00% <100.00%> (ø)
dotenv-linter/src/lib.rs 99.03% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Mar 31, 2023
@jklott jklott mentioned this pull request Mar 31, 2023
Closed
@jklott
Copy link
Contributor Author

jklott commented Mar 31, 2023

Can this get a review? The issue is here: #647

Both marked as stale today.

@DDtKey DDtKey changed the title Add "No difference found" when comparing two files with no difference. feat: add "No difference found" message on successful compare Mar 31, 2023
DDtKey
DDtKey approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@DDtKey DDtKey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 👍

I renamed PR to fits conventional commits & pass CI check.

LGTM

@github-actions github-actions bot removed the stale label Apr 1, 2023
@mgrachev mgrachev linked an issue Apr 3, 2023 that may be closed by this pull request
Proposal: Add text indicating "no difference" when running compare option. #647
Closed
@mgrachev mgrachev merged commit bb7dbd4 into dotenv-linter:master Apr 3, 2023
@mgrachev
Copy link
Member

mgrachev commented Apr 3, 2023

@Poxxy Thank you for your contribution 👏

@mgrachev mgrachev mentioned this pull request Aug 6, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrachev mgrachev mgrachev approved these changes

@DDtKey DDtKey DDtKey approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: Add text indicating "no difference" when running compare option.

4 participants

@jklott @codecov-commenter @mgrachev @DDtKey