KEMBAR78
refactor(dotenv-finder): use Builder pattern by mgrachev · Pull Request #900 · dotenv-linter/dotenv-linter · GitHub
Skip to content

refactor(dotenv-finder): use Builder pattern #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

refactor(dotenv-finder): use Builder pattern #900

merged 1 commit into from
Sep 3, 2025

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Sep 3, 2025

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 32.18391% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (800f492) to head (07fd200).

Files with missing lines Patch % Lines
dotenv-finder/src/lib.rs 0.00% 37 Missing ⚠️
dotenv-linter/src/lib.rs 0.00% 14 Missing ⚠️
dotenv-finder/src/quote.rs 82.35% 6 Missing ⚠️
dotenv-finder/src/file.rs 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   90.61%   90.32%   -0.30%     
==========================================
  Files          94       94              
  Lines        6044     6065      +21     
==========================================
+ Hits         5477     5478       +1     
- Misses        567      587      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgrachev mgrachev merged commit f13f0ef into master Sep 3, 2025
43 checks passed
@mgrachev mgrachev deleted the refactor-dotenv-finder branch September 3, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgrachev @codecov-commenter