KEMBAR78
How to log automatic 400 responses by tdykstra · Pull Request #12315 · dotnet/AspNetCore.Docs · GitHub
Skip to content

Conversation

@tdykstra
Copy link
Contributor

@tdykstra tdykstra commented May 7, 2019

Fixes #12157


### Log automatic 400 responses

For information about how to log automatic HTTP 400 responses, see [issue #12157 in the AspNetCore.Docs repo](https://github.com/aspnet/AspNetCore.Docs/issues/12157).
Copy link
Collaborator

@guardrex guardrex May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we standardize our engineering issue/PR links. I suggest basing them on their titles (unless the titles are really bad). The following is the format that I've been using, but I'd like to adopt a format that the team agrees on and use it everywhere. I'll keep an 👂 out for guidance from the team.

Suggested change
For information about how to log automatic HTTP 400 responses, see [issue #12157 in the AspNetCore.Docs repo](https://github.com/aspnet/AspNetCore.Docs/issues/12157).
For information on how to log automatic HTTP 400 responses, see [How automatically triggered model validation errors can be logged? (aspnet/AspNetCore.Docs #12157)](https://github.com/aspnet/AspNetCore.Docs/issues/12157).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to let people know they're linking out of the docs. And if we include the title in the link text we should change the title to make it as effectively descriptive as possible within a reasonable length limit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't control them on the engineering side, there was a case or two where I had to use a different title. IIRC, most of the engineering issue titles were fine.

It's just a personal thing, but I've usually been less concerned on the where-it-is aspect. I just put that under the umbrella of this is the Internet ... this is how the whole thing works. 😄

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anywho ... let me know if you cats standardize. Otherwise, I'll keep going. I haven't had negative feedback from a reader about any of my cross-links ...... yet 🤞.

@tdykstra tdykstra requested a review from scottaddie May 7, 2019 15:36
@tdykstra tdykstra merged commit d309fe4 into master May 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the tdykstra-patch-2 branch May 7, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to log automatic 400 responses on model validation errors

3 participants