[xabt] remove $(AndroidStripILAfterAOT)
#10204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #9577 Partially reverts 82a4092. We introduced an "experimental" property `$(AndroidStripILAfterAOT)` in .NET 8, which has a few flaws as mentioned in #9577. I've seen this come up on a couple customer issues, and the solution was to stop using the feature... Since, this feature is only available for Mono (not CoreCLR or NativeAOT), it feels like we should remove it from the codebase for now. We could bring it back in the future, if we also solved #9577.
jonathanpeppers
commented
Jun 16, 2025
| LdName="$(_LdName)" | ||
| LdFlags="$(_LdFlags)" | ||
| CollectTrimmingEligibleMethods="$(AndroidStripILAfterAOT)" | ||
| CollectTrimmingEligibleMethods="$(_AndroidCollectTrimmingEligibleMethods)" |
There was a problem hiding this comment.
I created a private property, $(_AndroidCollectTrimmingEligibleMethods), if someone wants to experiment with this in the future. This way it's possible to set it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9577
Partially reverts 82a4092.
We introduced an "experimental" property
$(AndroidStripILAfterAOT)in .NET 8, which has a few flaws as mentioned in #9577. I've seen this come up on a couple customer issues, and the solution was to stop using the feature...Since, this feature is only available for Mono (not CoreCLR or NativeAOT), it feels like we should remove it from the codebase for now. We could bring it back in the future, if we also solved #9577.