[native] Ensure function_name() is part of log message #10302
Conversation
Context: dotnet/runtime#117733 When a .NET for Android app aborts, the abort message should contain the file name, line number, column, and function name of the function which triggered the abort. Insteda, we get the filename, line number, and column, but we get `%s` for the function name: F monodroid: Abort at mono-log-adapter.cc:46:3 ('%s') Update the `log_fatal()` invocation within `mono-log-adapter.cc` to use `{}` instead of `%s`, in accordance with C++ `std::format`. This should cause `sloc.function_name()` to be properly part of the abort message.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a formatting issue in native logging code where function names were not being properly displayed in abort messages. Instead of showing the actual function name, abort messages were displaying the literal string %s.
- Updates the log format string to use C++
std::formatsyntax with{}instead of%s - Ensures that
sloc.function_name()is properly included in abort messages for better debugging
| log_fatal ( | ||
| category, | ||
| "Abort at {}:{}:{} ('%s')", | ||
| "Abort at {}:{}:{} ('{}')", |
There was a problem hiding this comment.
The format string has been updated to use {} for the function name, but there's no corresponding argument being passed for this placeholder. The diff shows the format string change but doesn't show the function_name argument being added to the log_fatal call.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
I see std.function_name:
android/src/native/mono/shared/helpers.cc
Lines 36 to 43 in 92d48f4
Because this is on multiple lines, I bet the AI didn't actually see the full method...
2 participants
Context: dotnet/runtime#117733
When a .NET for Android app aborts, the abort message should contain the file name, line number, column, and function name of the function which triggered the abort.
Insteda, we get the filename, line number, and column, but we get
%sfor the function name:Update the
log_fatal()invocation withinmono-log-adapter.ccto use{}instead of%s, in accordance with C++std::format. This should causesloc.function_name()to be properly part of the abort message.