Fixed potential torn reads in EventCounters #22923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backing fields for the counters are `long`, so there was potential torn read on 32-bit platforms. `Volatile.Read` ensures that the value is read in a atomic way, so no torn reads can occur.
|
See ongoing conversation in npgsql/npgsql#3223 (comment) |
|
Updated to use |
Too eagerly with find & replace -- sorry.
roji
reviewed
Oct 9, 2020
Of course 😃 --> 2d39eb9 |
|
@dotnet/efteam Should we take this in 5.0? |
|
I'm not sure this qualifies... It only affects 32-bit systems (really rare nowadays), and even there is really non-fatal. On the flip-side, the risk here is extremely low. |
|
Let's discuss in triage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backing fields for the counters are
long, so there was potential torn read on 32-bit platforms.Volatile.Readensures that the value is read in a atomic way, so no torn reads can occur.