KEMBAR78
Simplify string.IsNullOrEmpty translation for SqlServer by Marusyk · Pull Request #23039 · dotnet/efcore · GitHub
Skip to content

Conversation

@Marusyk
Copy link
Member

@Marusyk Marusyk commented Oct 18, 2020

Extends SqlServerStringMethodTranslator (without changes in StringMethodTranslator) to simplify string.IsNullOrEmpty translation

@value IS NULL OR @value LIKE N''

instead of

@value IS NULL OR @value = N''

Fixes #23037

Please review
Thank you in advance

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roji
Copy link
Member

roji commented Oct 18, 2020

Unrelated build failures (dotnet-install failing on macos), merging.

@roji roji merged commit 6b67689 into dotnet:main Oct 18, 2020
@Marusyk Marusyk deleted the rmarusyk/23037 branch October 18, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SqlServer: Translate string.IsNullOrEmpty with LIKE

3 participants