Support Precision Attribute #23424
Support Precision Attribute #23424
Conversation
src/EFCore.Design/Scaffolding/Internal/CSharpEntityTypeGenerator.cs
Outdated
Show resolved
Hide resolved
| precisionAttribute.AddParameter(_code.Literal(scale.Value)); | ||
| } | ||
|
|
||
| _sb.AppendLine(precisionAttribute.ToString()); |
There was a problem hiding this comment.
Also add a check in CSharpDbContextGenerator.GenerateProperty to avoid adding fluent API calls for precision if data annotations are used
There was a problem hiding this comment.
Hi @AndriySvyryd I also notice that my previous PR for Unicode Attribute is missing your check suggestion. That PR is already merged so I wonder I could include this small fix in this PR or I will create a new PR for it ? I also notice that there are no test case for checking IsUnicode fluent api to be generated inside https://github.com/dotnet/efcore/blob/main/test/EFCore.Design.Tests/Scaffolding/Internal/CSharpDbContextGeneratorTest.cs
There was a problem hiding this comment.
Yes, include it in this PR
There was a problem hiding this comment.
Thanks @AndriySvyryd I've updated my PR.
src/EFCore/Metadata/Conventions/PrecisionAttributeConvention.cs
Outdated
Show resolved
Hide resolved
|
Thanks for your contribution! |
ajcvickers
added
customer-reported
community-contribution
and removed
customer-reported
labels
3 participants
Fix #17914