Microsoft.Data.Sqlite: Enable nullable reference types #23549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
commented
Dec 1, 2020
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
bricelam
commented
Dec 2, 2020
src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateAggregate.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 2, 2020
smitpatel
reviewed
Dec 2, 2020
smitpatel
reviewed
Dec 2, 2020
smitpatel
reviewed
Dec 2, 2020
roji
reviewed
Dec 2, 2020
src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateAggregate.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateAggregate.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 2, 2020
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
bricelam
force-pushed
the
nrt
branch
3 times, most recently
from
25d9c58 to
b8cba47
Compare
|
@roji This should be good to go if you want to give it a final review. |
roji
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19007
Also updates the behavior of SqliteDataReader.GetChars when buffer is null and GetBytes when dataOffset is specified.