Scaffold IsFixedLength() instead of IsFixedLength(true) #23666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
reviewed
Dec 12, 2020
test/EFCore.Design.Tests/Scaffolding/Internal/CSharpDbContextGeneratorTest.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Design.Tests/Scaffolding/Internal/CSharpDbContextGeneratorTest.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Design.Tests/Scaffolding/Internal/CSharpDbContextGeneratorTest.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Internal/RelationalPropertyExtensions.cs
Outdated
Show resolved
Hide resolved
roji
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run efcore-ci (Build Windows) |
|
No pipelines are associated with this pull request. |
|
Can this be shipped with 5.0.2? |
|
@Saibamen as this is purely a cosmetic issue rather than a bug, there's little chance this could be considered for a 5.0 patch... |
|
So there is nothing to wait for. This is just cosmetic issue, so there is no breaking changes |
|
@Saibamen you probably want to take a look at the patching policy, specifically about the part where patches are about fixing bugs. Any change implies risk, so we don't merge cosmetics to patch releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23473
IsFixedLength()