KEMBAR78
Change the conflicted error number of `Access-modifies-to-auto-properties` by ijklam · Pull Request #17522 · dotnet/fsharp · GitHub
Skip to content

Change the conflicted error number of Access-modifies-to-auto-properties #17522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 70 commits into from
Aug 12, 2024
Merged

Change the conflicted error number of Access-modifies-to-auto-properties #17522

merged 70 commits into from
Aug 12, 2024

Conversation

@ijklam
Copy link
Contributor

@ijklam ijklam commented Aug 12, 2024

Description

Complete unfinished change of #16861

Change the conflicted error number of Access-modifies-to-auto-properties

ijklam and others added 30 commits February 10, 2024 17:35
@ijklam
Allow access modifies to auto properties
ec79e85
@ijklam
move types
47f34ab
@ijklam
update release note
76e615b
@ijklam
Put it under preview flag
5c3b230
@ijklam
add and update baseline
f974953
@ijklam
move checks leave parser
3588ada
@ijklam
update ServiceNavigation; fantomas
09311ef
@ijklam
add tests
dc04a91
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
be9cec3
@ijklam
fix tests
6cf5d1c
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
d7ae5fb
@ijklam
fix tests
dbc52d4
@ijklam
Merge branch 'access-modifies-to-auto-properties' of https://github.c…
f8c2f5b 
…om/Tangent-90/fsharp into access-modifies-to-auto-properties
@ijklam
fix tests
fbe1736
@ijklam
fix tests
8e3a529
@ijklam
fix
88e1678
@ijklam
fix
304348f
@ijklam
fix
f82df9e
@ijklam
fix
97933a5
@ijklam
add spaces
5a2d1fe
@ijklam
fix grammar
55e9081
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
01d093e
@ijklam
support in signature file
34a0010
@ijklam
update test
25b75f6
@ijklam
Merge branch 'main' into access-modifies-to-auto-properties
6c4ea36
@ijklam
Update preview.md
eba76af
@ijklam
fix
a6d5a6d 
support for tooling
@ijklam
fix
6d27474
@ijklam
format
85f83c0 
fix sig file generate
@ijklam
put tooling new feature under langFeature flag
5d2ae12
ijklam and others added 18 commits May 20, 2024 22:00
@ijklam
Merge branch 'main' into access-modifies-to-auto-properties
8305a85
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
aa7790f
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
ede6c14
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
0249ab4
@vzarytovskii
Fix tests
ecc647c
@vzarytovskii
Updated release notes
70ba918
@psfinaki
Merge branch 'main' into access-modifies-to-auto-properties
4438cd6
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
b501108
@vzarytovskii
Update bsl
6838437
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
c037354
@vzarytovskii
Fix baseline
b344aea
@ijklam
Merge remote-tracking branch 'upstream/main' into access-modifies-to-…
d5a3509 
…auto-properties
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
dc427d8
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
ba25173
@vzarytovskii
Merge branch 'main' into access-modifies-to-auto-properties
3adaf31
@ijklam
Update FSComp.txt
fdce4c5
@ijklam
Some unfinished changes
489e7fa
@ijklam
Merge branch 'access-modifies-to-auto-properties' of https://github.c…
ddb6302 
…om/Tangent-90/fsharp into access-modifies-to-auto-properties
@ijklam ijklam requested a review from a team as a code owner August 12, 2024 13:42
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@psfinaki
Copy link
Contributor

Thanks for addressing this. I think HashDirectives tests need update also.

@vzarytovskii
Copy link
Member

That's weird, I swear I've fixed it. Must've been something else which was merged in between.

@vzarytovskii vzarytovskii enabled auto-merge (squash) August 12, 2024 20:06
@vzarytovskii
Copy link
Member

Thanks for staying on top of it, sorry it was taking that long to get it in.

@vzarytovskii vzarytovskii merged commit f61dc16 into dotnet:main Aug 12, 2024
This was referenced Aug 20, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijklam @psfinaki @vzarytovskii