KEMBAR78
Error on invalid declarations in type definitions. by edgarfgp · Pull Request #18813 · dotnet/fsharp · GitHub
Skip to content

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Aug 3, 2025

Description

Fixes #10066

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md
LanguageFeatures.fsi docs/release-notes/.Language/preview.md

@edgarfgp edgarfgp force-pushed the fix-10066 branch 2 times, most recently from 082655a to 17e2f1c Compare August 15, 2025 10:10
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, as always Edgar :)

@edgarfgp edgarfgp requested review from T-Gro and auduchinok August 15, 2025 15:30
@edgarfgp
Copy link
Contributor Author

@T-Gro Any chance I get some help updating the last failing .bsl tests. Im on a macOS and for some reason the use usual export TEST_UPDATE_BSL=1 & dotnet test does not work. Thanks

@edgarfgp
Copy link
Contributor Author

This is ready :)

@T-Gro T-Gro enabled auto-merge (squash) August 25, 2025 14:58
@T-Gro
Copy link
Member

T-Gro commented Aug 26, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro T-Gro merged commit e513690 into dotnet:main Aug 26, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Compiler allows what looks like a module nested inside of a type, but isn't

6 participants