[msbuild] Enable signing by default for all platforms. Fixes #18469. #20824

rolfbjarne · 2024-07-05T15:30:20Z

Enable signing by default for all platforms, because that's what Xcode does.

This fixes an issue for simulator builds, where certain features don't work
unless the app is signed (#18469).

It also simplifies and unifies our code to detect signing identities, so that
it's much more shared/equal beteween platforms.

However, simulator builds have a few peculiarities:

The placeholder code signing certificate ("-", or what Xcode calls "Sign to
Run Locally") is always used.
Any entitlements the app requests will be embedded in the native executable
in a Mach-O section named __ents_der.
The actual app signature only demands the
"com.apple.security.get-task-allow" entitlement (which seems to be allowed
without a provisioning profile when using the placeholder code signing
certificate).
No provisioning profiles are used.

In order to provide a fairly decent way of restoring old behavior (not signing
simulator builds), I created a public property to determine whether we're
building for the simulator (SdkIsSimulator), and added documentation on how to
use this new property to disable code signing.

Fixes #18469.

vs-mobiletools-engineering-service2 · 2024-07-05T17:16:39Z

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-07-05T17:27:04Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0240940587615ef43459666514f6be3923b7d929 [PR build]

vs-mobiletools-engineering-service2 · 2024-07-05T17:31:05Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0240940587615ef43459666514f6be3923b7d929 [PR build]

vs-mobiletools-engineering-service2 · 2024-07-05T17:32:00Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 0240940587615ef43459666514f6be3923b7d929 [PR build]

vs-mobiletools-engineering-service2 · 2024-07-05T17:32:56Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0240940587615ef43459666514f6be3923b7d929 [PR build]

vs-mobiletools-engineering-service2 · 2024-07-05T17:49:52Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0240940587615ef43459666514f6be3923b7d929 [PR build]

vs-mobiletools-engineering-service2 · 2024-07-05T18:00:46Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0240940587615ef43459666514f6be3923b7d929 [PR build]

vs-mobiletools-engineering-service2 · 2024-07-05T19:17:41Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 168 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0240940587615ef43459666514f6be3923b7d929 [PR build]

github-actions · 2025-05-05T10:30:11Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-06-02T17:44:29Z

✅ [CI Build #af85731] Build passed (Build packages) ✅

Pipeline on Agent
Hash: af85731cc75137040e566ed48f1f4f0faf9d9c19 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-02T17:45:50Z

✅ [PR Build #af85731] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: af85731cc75137040e566ed48f1f4f0faf9d9c19 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-02T18:12:38Z

🔥 Failed to compare API and create generator diff 🔥

Error: 'make' failed for the hash d1efcd2.

Pipeline on Agent
Hash: af85731cc75137040e566ed48f1f4f0faf9d9c19 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-02T18:15:44Z

✅ [CI Build #af85731] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: af85731cc75137040e566ed48f1f4f0faf9d9c19 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-02T18:32:12Z

💻 [CI Build #af85731] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: af85731cc75137040e566ed48f1f4f0faf9d9c19 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-02T18:41:10Z

💻 [CI Build #4f33f82] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 4f33f82a1f7047a08fa3696470d4909a7a0daaf5 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-03T02:08:59Z

💻 [CI Build #af85731] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: af85731cc75137040e566ed48f1f4f0faf9d9c19 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-03T06:32:43Z

💻 [CI Build #af85731] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: af85731cc75137040e566ed48f1f4f0faf9d9c19 [PR build]

vs-mobiletools-engineering-service2 · 2025-06-03T06:38:35Z

🚀 [CI Build #af85731] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: af85731cc75137040e566ed48f1f4f0faf9d9c19 [PR build]

dalexsoto

❤️

rolfbjarne mentioned this pull request Jul 5, 2024

[msbuild] Sign simulator apps by default. Fixes #18469. #19544

Closed

rolfbjarne force-pushed the dev/rolf/codesign-simulator-by-default branch from 0240940 to f953e5d Compare May 2, 2025 06:31

This comment has been minimized.

Sign in to view

Auto-format source code

af85731

This comment has been minimized.

Sign in to view

rolfbjarne changed the title ~~[msbuild] Sign simulator apps by default. Fixes #18469.~~ [msbuild] Enable signing by default for all platforms. Fixes #18469. Jun 3, 2025

rolfbjarne marked this pull request as ready for review June 3, 2025 11:46

rolfbjarne requested review from emaf and mauroa as code owners June 3, 2025 11:46

emaf approved these changes Jun 3, 2025

View reviewed changes

dalexsoto approved these changes Jun 5, 2025

View reviewed changes

rolfbjarne merged commit af99cee into main Jun 5, 2025
40 checks passed

rolfbjarne deleted the dev/rolf/codesign-simulator-by-default branch June 5, 2025 12:23

LoopedBard3 mentioned this pull request Aug 8, 2025

Update iOS builds to disable code signing again dotnet/performance#4902

Merged

[msbuild] Enable signing by default for all platforms. Fixes #18469. #20824

[msbuild] Enable signing by default for all platforms. Fixes #18469. #20824

Uh oh!

Conversation

rolfbjarne commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 5, 2024

📚 [CI Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 5, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 5, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 5, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 5, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 5, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 5, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 5, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented May 5, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 2, 2025

✅ [CI Build #af85731] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 2, 2025

✅ [PR Build #af85731] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 2, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 2, 2025

✅ [CI Build #af85731] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 2, 2025

💻 [CI Build #af85731] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

This comment has been minimized.

rolfbjarne commented Jul 5, 2024 •

edited

Loading