.NET: Add AppBundleResourcePrefix property to unify resource prefix properties #22840

Copilot · 2025-05-20T06:20:20Z

This PR unifies the various resource prefix properties (IPhoneResourcePrefix, MonoMacResourcePrefix, and XamMacResourcePrefix) into a single property (AppBundleResourcePrefix) for use in .NET projects.

The implementation:

Adds a new AppBundleResourcePrefix property in Xamarin.Shared.props with a default value of "Resources"
Updates the property precedence to use AppBundleResourcePrefix first, then fall back to the platform-specific properties
Maintains backward compatibility by having legacy properties default to the new property if they're not explicitly set
Updates comments in MSBuild files to reflect the changes
Updates documentation in build-properties.md to document the new property and add recommendations for using it instead of the legacy properties

Users can now specify a single resource prefix property that works across all platforms:

<PropertyGroup>
  <AppBundleResourcePrefix>Resources</AppBundleResourcePrefix>
</PropertyGroup>

Legacy properties will continue to work for backward compatibility, but the new property is recommended for new .NET projects.

Fixes #12808.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Copilot · 2025-05-20T07:02:41Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: adbbea8c-ae8f-4d37-855a-55e9081fdcaf

Sorry for the inconvenience!

Copilot · 2025-05-20T07:03:13Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 34da11d9-8e7f-46c5-bba7-874e7121d44b

Sorry for the inconvenience!

Copilot · 2025-05-20T07:16:53Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 50b8f969-af2e-4eb2-bc53-4d6971523d27

Sorry for the inconvenience!

Copilot · 2025-05-20T07:27:38Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: a9b37447-7b86-4830-a2b8-0bcd37973b2b

Sorry for the inconvenience!

Copilot · 2025-05-20T07:38:19Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 370493be-7783-4567-8bc9-4ac2f3cbfdb9

Sorry for the inconvenience!

Copilot · 2025-05-20T08:13:23Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 9042b1dd-9b8b-4544-af91-39c6b90ad995

Sorry for the inconvenience!

Copilot · 2025-05-20T08:14:42Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 52262bc0-5eed-4327-8bd5-b582774803a8

Sorry for the inconvenience!

Copilot · 2025-05-20T08:18:40Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 1931d688-99ea-4d07-92a6-87731e6e4648

Sorry for the inconvenience!

Copilot · 2025-05-20T08:23:38Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 6455321f-0d08-492b-8995-7073e97a7b7d

Sorry for the inconvenience!

Copilot · 2025-05-20T08:26:32Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: aafb4e88-072a-4c4b-aa75-928f0908e14c

Sorry for the inconvenience!

Copilot · 2025-06-27T13:08:37Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 7a77223b-47f5-4fad-acf9-443dcdead15d

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T11:23:50Z

✅ [PR Build #60406bc] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T11:23:55Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 7f3ac477-7ebe-4627-8658-afcb35d684cf

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T11:50:08Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T11:50:12Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: d436e07c-e31d-462e-9c1c-55b1cb25199f

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T11:50:17Z

✅ [CI Build #60406bc] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T11:50:22Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 4e96b398-14f9-42b0-88e6-f14bf875ea86

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T12:22:17Z

✅ [CI Build #60406bc] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T12:22:22Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 48bae836-bc8c-44d2-be44-f47e9ccf1f4a

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T12:33:40Z

💻 [CI Build #60406bc] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T12:33:45Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 58352909-2980-4cbe-8a87-b7c6395c2b24

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T12:38:18Z

💻 [CI Build #60406bc] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T12:38:23Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 75d6ba25-6631-4ff6-9cce-281987604af0

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T12:38:54Z

💻 [CI Build #60406bc] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T12:39:00Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 653da6d8-4296-4290-9a75-538dab64b6e8

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T12:40:21Z

💻 [CI Build #60406bc] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T12:40:25Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 427fdeb5-44ff-4403-862c-3ea4f11db2b2

Sorry for the inconvenience!

vs-mobiletools-engineering-service2 · 2025-07-10T13:37:03Z

🚀 [CI Build #60406bc] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 60406bc2e1241310e614faeea9bfadc0002db442 [PR build]

Copilot · 2025-07-10T13:37:08Z

@vs-mobiletools-engineering-service2 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 00550572-93ed-45d2-9c7d-d2df5c491f72

Sorry for the inconvenience!

Initial plan for issue

910098e

Copilot AI assigned Copilot and rolfbjarne May 20, 2025

Copilot started work on behalf of rolfbjarne May 20, 2025 06:20 View session

Copilot AI and others added 2 commits May 20, 2025 06:23

Add AppBundleResourcePrefix property and update property precedence

f1cccf3

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Update documentation for AppBundleResourcePrefix

3f8a375

Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] .NET: Unify the MonoMacResourcePrefix, XamMacResourcePrefix and IPhoneResourcePrefix MSBuild properties~~ .NET: Add AppBundleResourcePrefix property to unify resource prefix properties May 20, 2025

Copilot AI requested a review from rolfbjarne May 20, 2025 06:26

Copilot finished work on behalf of rolfbjarne May 20, 2025 06:26

This comment has been minimized.

Sign in to view

Merge branch 'main' into copilot/fix-12808

60406bc

rolfbjarne approved these changes Jul 10, 2025

View reviewed changes

rolfbjarne marked this pull request as ready for review July 10, 2025 11:05

rolfbjarne requested review from emaf and mauroa as code owners July 10, 2025 11:05

dalexsoto approved these changes Jul 10, 2025

View reviewed changes

mauroa approved these changes Jul 16, 2025

View reviewed changes

emaf approved these changes Jul 16, 2025

View reviewed changes

rolfbjarne merged commit 49e8c95 into main Jul 16, 2025
44 checks passed

rolfbjarne deleted the copilot/fix-12808 branch July 16, 2025 15:05

.NET: Add AppBundleResourcePrefix property to unify resource prefix properties #22840

.NET: Add AppBundleResourcePrefix property to unify resource prefix properties #22840

Uh oh!

Conversation

Copilot AI commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

Copilot AI commented May 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Copilot AI commented Jun 27, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 10, 2025

✅ [PR Build #60406bc] Build passed (Detect API changes) ✅

Uh oh!

Copilot AI commented Jul 10, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 10, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

Copilot AI commented Jul 10, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 10, 2025

✅ [CI Build #60406bc] Build passed (Build packages) ✅

Uh oh!

Copilot AI commented Jul 10, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 10, 2025

✅ [CI Build #60406bc] Build passed (Build macOS tests) ✅

Uh oh!

Copilot AI commented Jul 10, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 10, 2025

💻 [CI Build #60406bc] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

Copilot AI commented Jul 10, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 10, 2025

💻 [CI Build #60406bc] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

Copilot AI commented Jul 10, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 10, 2025

💻 [CI Build #60406bc] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

Copilot AI commented Jul 10, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 10, 2025

💻 [CI Build #60406bc] Tests on macOS M1 - Mac Ventura (13) passed 💻

Copilot AI commented May 20, 2025 •

edited

Loading