[RGen] Fix the arguments passing when the parameter is by ref. #22895

mandel-macaque · 2025-05-24T00:24:24Z

There are 3 things to focus on:

Ensure the correct argument name is used if a conversion is needed.
If no conversion is needed use ByRef
Ensure we use the correct ref kind token.

New tests added and old updated.

There are 3 things to focs on: 1. Ensure the correct argumnet name is used if a conversion is needed. 2. If no conversion is needed use ByRef 3. Ensure we use the correct ref kind token. New tests added and old updated.

vs-mobiletools-engineering-service2 · 2025-05-27T01:32:01Z

✅ [CI Build #a66dac9] Build passed (Build packages) ✅

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T01:33:12Z

✅ [PR Build #a66dac9] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T01:59:00Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T02:37:20Z

✅ [CI Build #a66dac9] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T02:48:53Z

💻 [CI Build #a66dac9] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T02:50:15Z

💻 [CI Build #a66dac9] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T02:50:38Z

💻 [CI Build #a66dac9] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T14:40:57Z

💻 [CI Build #a66dac9] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T14:45:53Z

🔥 [CI Build #a66dac9] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 0 tests failed, 116 tests passed.

Failures

❌ windows tests

🔥 Failed catastrophically on VSTS: test results - windows (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a66dac9088d53fc89af4c44a08e5e6d20809b61e [PR build]

mandel-macaque and others added 2 commits May 23, 2025 20:22

[RGen] Fix the arguments passing when the parameter is by ref.

75490ed

There are 3 things to focs on: 1. Ensure the correct argumnet name is used if a conversion is needed. 2. If no conversion is needed use ByRef 3. Ensure we use the correct ref kind token. New tests added and old updated.

Auto-format source code

dde8397

This comment has been minimized.

Sign in to view

StephaneDelcroix approved these changes May 26, 2025

View reviewed changes

rolfbjarne approved these changes May 26, 2025

View reviewed changes

Merge branch 'main' into dev/mandel/fix-general-ref-args

a66dac9

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 395db0f into main May 27, 2025
41 of 44 checks passed

mandel-macaque deleted the dev/mandel/fix-general-ref-args branch May 27, 2025 14:48

[RGen] Fix the arguments passing when the parameter is by ref. #22895

[RGen] Fix the arguments passing when the parameter is by ref. #22895

Uh oh!

Conversation

mandel-macaque commented May 24, 2025 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 27, 2025

✅ [CI Build #a66dac9] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 27, 2025

✅ [PR Build #a66dac9] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 27, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 27, 2025

✅ [CI Build #a66dac9] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 27, 2025

💻 [CI Build #a66dac9] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 27, 2025

💻 [CI Build #a66dac9] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 27, 2025

💻 [CI Build #a66dac9] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 27, 2025

💻 [CI Build #a66dac9] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 27, 2025

🔥 [CI Build #a66dac9] Test results 🔥

Test results

Failures

❌ windows tests

Successes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mandel-macaque commented May 24, 2025 •

edited by rolfbjarne

Loading