KEMBAR78
[dotnet] Fix dependency tracking for aot compilation. Fixes #21061. by rolfbjarne · Pull Request #22906 · dotnet/macios · GitHub
Skip to content

Conversation

rolfbjarne
Copy link
Member

Store the non-file inputs to the AOT compiler in a cache file, and if these inputs
change, then clean the entire cache of AOT-compiled output. This is implemented by
computing a hash of all these inputs (properties), store the hash to a file, and
overwrite the file if the hash changes. Then in a subsequent target, we wipe the
AOT compiler cache if the file with the hash value changed.

This is a similar implementation of how the csc task (C# compiler) creates a hash
of the compiler input in order to know when to re-execute the C# compiler.

Fixes #21061.

Store the non-file inputs to the AOT compiler in a cache file, and if these inputs
change, then clean the entire cache of AOT-compiled output. This is implemented by
computing a hash of all these inputs (properties), store the hash to a file, and
overwrite the file if the hash changes. Then in a subsequent target, we wipe the
AOT compiler cache if the file with the hash value changed.

This is a similar implementation of how the csc task (C# compiler) creates a hash
of the compiler input in order to know when to re-execute the C# compiler.

Fixes #21061.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #810e277] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #810e277] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #810e277] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #810e277] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #810e277] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #810e277] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #810e277] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #810e277] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 810e2773a5726ea1ff3b3014639ca488b16ebdb0 [PR build]

@rolfbjarne rolfbjarne merged commit ca3aaa6 into main May 28, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/incremental-builds-fixes branch May 28, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incremental builds don't work correctly when changing the UseInterpreter value

3 participants