KEMBAR78
[Nomenclator] Deal correctly with nested classed. by mandel-macaque · Pull Request #22943 · dotnet/macios · GitHub
Skip to content

Conversation

mandel-macaque
Copy link
Member

Nested classes names will contain a '.' to indicate they are nested but leaving the '.' will result in an invalid name.

Nested classes names will contain a '.' to indicate they are nested but
leaving the '.' will result in an invalid name.
@mandel-macaque mandel-macaque force-pushed the dev/mandel/nomenclator-nested-types branch from 12f06eb to 58fcce6 Compare May 29, 2025 17:51
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #58fcce6] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 58fcce6c7d9f48c4b97f5100f29356e6b8b44496 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #58fcce6] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 58fcce6c7d9f48c4b97f5100f29356e6b8b44496 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #58fcce6] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 58fcce6c7d9f48c4b97f5100f29356e6b8b44496 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 58fcce6c7d9f48c4b97f5100f29356e6b8b44496 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build #58fcce6] Tests on macOS X64 - Mac Sonoma (14) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 58fcce6c7d9f48c4b97f5100f29356e6b8b44496 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #58fcce6] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 58fcce6c7d9f48c4b97f5100f29356e6b8b44496 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #58fcce6] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 58fcce6c7d9f48c4b97f5100f29356e6b8b44496 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #58fcce6] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 58fcce6c7d9f48c4b97f5100f29356e6b8b44496 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #c187975] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 123 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c187975106066fa7f516f68315000d4b13569e52 [PR build]

@mandel-macaque mandel-macaque merged commit 5658e40 into main May 29, 2025
40 checks passed
@mandel-macaque mandel-macaque deleted the dev/mandel/nomenclator-nested-types branch May 29, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants