KEMBAR78
[RGen] Factory method to perform the init of our params in the native invoke. by mandel-macaque · Pull Request #22961 · dotnet/macios · GitHub
Skip to content

[RGen] Factory method to perform the init of our params in the native invoke. #22961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

[RGen] Factory method to perform the init of our params in the native invoke. #22961

merged 2 commits into from
Jun 2, 2025

Conversation

@mandel-macaque
Copy link
Member

All out parameters have to have a default value in the Invoke of the NI* classes. Ref parameters do not need to be init, same with in params.

mandel-macaque and others added 2 commits May 30, 2025 11:35
@mandel-macaque
[RGen] Factory method to perform the init of our params in the native…
853d369 
… invoke.

All out parameters have to have a default value in the Invoke of the NI*
classes. Ref parameters do not need to be init, same with in params.
Auto-format source code
2fa3fcc
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #2fa3fcc] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #2fa3fcc] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #2fa3fcc] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #2fa3fcc] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #2fa3fcc] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #2fa3fcc] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #2fa3fcc] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #2fa3fcc] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 1 tests failed, 113 tests passed.

Failures

❌ monotouch tests (MacCatalyst)

1 tests failed, 10 tests passed.
  • monotouch-test/Mac Catalyst/Release (static registrar): Failed (Test run failed.
    Tests run: 3205 Passed: 3065 Inconclusive: 13 Failed: 1 Ignored: 139)

Html Report (VSDrops) Download

❌ windows tests

🔥 Failed catastrophically on VSTS: test results - windows (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2fa3fcc9db63581c9b53051a91d47437c16d8c55 [PR build]

@mandel-macaque
Copy link
Member Author

Failing tests are unrelated to the current code changes.

@mandel-macaque mandel-macaque merged commit b3a63b5 into main Jun 2, 2025
36 of 40 checks passed
@mandel-macaque mandel-macaque deleted the dev/mandel/native-invoke-init-parameter branch June 2, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne