KEMBAR78
[msbuild] Correctly handle 'SkipCodesignItems' that are directories. Fixes #19222. by rolfbjarne · Pull Request #22962 · dotnet/macios · GitHub
Skip to content

[msbuild] Correctly handle 'SkipCodesignItems' that are directories. Fixes #19222. #22962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2025
Merged

[msbuild] Correctly handle 'SkipCodesignItems' that are directories. Fixes #19222. #22962

merged 4 commits into from
Jun 3, 2025
+96 −5

Conversation

@rolfbjarne
Copy link
Member

Handle the following cases:

  • If the item to be skipped is a file, checking if it's a directory first will fail.
  • If the item is a directory, we need to canonicalize it to have a trailing slash.

Fixes #19222.

@rolfbjarne
[msbuild] Correctly handle 'SkipCodesignItems' that are directories. F…
ee2bf96 
…ixes #19222.

Handle the following cases:

* If the item to be skipped is a file, checking if it's a directory first will fail.
* If the item is a directory, we need to canonicalize it to have a trailing slash.

Fixes #19222.
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners May 30, 2025 17:03
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #73d79b7] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #73d79b7] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #73d79b7] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #73d79b7] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #73d79b7] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #73d79b7] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #73d79b7] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #73d79b7] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 73d79b77eb793d173f1007ba6b5e298bacd6662f [PR build]

@rolfbjarne rolfbjarne merged commit 1695cd7 into main Jun 3, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/issue-19222 branch June 3, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@emaf emaf emaf approved these changes

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SkipCodesignItems does not work when the app bundle specified (not a single file)

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @emaf