KEMBAR78
[msbuild] Don't connect to a remote mac for library projects that are bundling original resources. by rolfbjarne · Pull Request #22984 · dotnet/macios · GitHub
Skip to content

[msbuild] Don't connect to a remote mac for library projects that are bundling original resources. #22984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

[msbuild] Don't connect to a remote mac for library projects that are bundling original resources. #22984

merged 2 commits into from
Jun 17, 2025

Conversation

@rolfbjarne
Copy link
Member

Recently we added support for fully building library and binding projects on
Windows, without connecting to a remote Mac.

This fix makes it so that we won't connect to the Mac when it's not needed.

@rolfbjarne
[msbuild] Don't connect to a remote mac for library projects that are…
8420c21 
… bundling origin resources.

Recently we added support for fully building library and binding projects on
Windows, without connecting to a remote Mac.

This fix makes it so that we won't connect to the Mac when it's not needed.
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #e65c6d3] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #e65c6d3] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #e65c6d3] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e65c6d3] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e65c6d3] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e65c6d3] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e65c6d3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #e65c6d3] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 118 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e65c6d37609ee8e1973d7a0b63791caa8fba2c9f [PR build]

@rolfbjarne rolfbjarne marked this pull request as ready for review June 5, 2025 12:19
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners June 5, 2025 12:19
@rolfbjarne rolfbjarne changed the title [msbuild] Don't connect to a remote mac for library projects that are bundling origin resources. [msbuild] Don't connect to a remote mac for library projects that are bundling original resources. Jun 16, 2025
@rolfbjarne rolfbjarne merged commit c3de9b9 into main Jun 17, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/no-mac-connection-binding-projects branch June 17, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@mauroa mauroa mauroa approved these changes

@emaf emaf emaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque @mauroa @emaf