[RGen] Add factory method to return a smart enum value from a NSString. #23027
Conversation
Add a factory method that will return the expression needed to get a SmartEnum from a NSString value.
There was a problem hiding this comment.
Pull Request Overview
The PR introduces a new factory method to generate syntax for converting an NSString into a SmartEnum value, along with a corresponding unit test.
- Added
GetSmartEnunFromNSStringinBindingSyntaxFactory.ObjCRuntime.csto emit an invocation of the SmartEnum extension’sGetValuemethod. - Documented the new method with XML comments (including an exception tag).
- Added
GetSmartEnunFromNSStringTestto verify the generated syntax string.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/rgen/Microsoft.Macios.Generator.Tests/Emitters/BindingSyntaxFactoryObjCRuntimeTests.cs | Added a test verifying the syntax emitted by the new factory method. |
| src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.ObjCRuntime.cs | Implemented GetSmartEnunFromNSString and its XML documentation. |
Comments suppressed due to low confidence (3)
src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.ObjCRuntime.cs:654
- [nitpick] There's a typo in the method name:
GetSmartEnunFromNSStringshould beGetSmartEnumFromNSStringto reflect 'Enum' correctly.
internal static InvocationExpressionSyntax GetSmartEnunFromNSString (in TypeInfo typeInfo, ArgumentSyntax argument)
tests/rgen/Microsoft.Macios.Generator.Tests/Emitters/BindingSyntaxFactoryObjCRuntimeTests.cs:972
- [nitpick] The test name repeats the typo from the factory method. Consider renaming to
GetSmartEnumFromNSStringTestfor consistency.
void GetSmartEnunFromNSStringTest ()
src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.ObjCRuntime.cs:653
- The documentation mentions an
ArgumentExceptionbut the method does not validatetypeInfoor throw. Either implement the validation or remove/update the exception tag.
/// <exception cref="ArgumentException">Thrown if <paramref name="typeInfo"/> is not a smart enum.</exception>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #74cc81c] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #74cc81c] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #74cc81c] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #74cc81c] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #74cc81c] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #74cc81c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #74cc81c] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
mandel-macaque
changed the title
🔥 [CI Build #74cc81c] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 0 tests failed, 120 tests passed. Failures❌ windows tests🔥 Failed catastrophically on VSTS: test results - windows (no summary found). Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Windows tests are unrelated to the code changes. |
4 participants
Add a factory method that will return the expression needed to get a SmartEnum from a NSString value.