[AppKit] Fix Action based delegate signatures. #23246

mandel-macaque · 2025-07-01T22:07:44Z

No description provided.

rolfbjarne · 2025-07-02T14:33:40Z

src/appkit.cs

 		[Async]
 		[Export ("setDefaultApplicationAtURL:toOpenContentTypeOfFileAtURL:completionHandler:")]
-		void SetDefaultApplicationToOpenContentType (NSUrl applicationUrl, NSUrl url, [NullAllowed] Action<NSError> completionHandler);
+		void SetDefaultApplicationToOpenContentType (NSUrl applicationUrl, NSUrl url, [NullAllowed] Action<NSError?> completionHandler);


While this is correct, it doesn't currently change anything in the generated code, because bgen doesn't understand nullability annotations in generic types.

I know, but rgen does, and I need to update the delegates before we migrate.

vs-mobiletools-engineering-service2 · 2025-07-16T20:45:10Z

✅ [CI Build #0105255] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-16T20:46:22Z

✅ [PR Build #0105255] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-16T21:13:19Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-16T21:18:06Z

✅ [CI Build #0105255] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-16T21:30:12Z

💻 [CI Build #0105255] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-16T21:31:02Z

💻 [CI Build #0105255] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-16T21:32:23Z

💻 [CI Build #0105255] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-16T21:32:37Z

💻 [CI Build #0105255] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

vs-mobiletools-engineering-service2 · 2025-07-16T22:21:24Z

🚀 [CI Build #0105255] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0105255cc5018099762f304c3822c62571da0eb5 [PR build]

[AppKit] Fix Action based delegate signatures.

afe2e6b

mandel-macaque requested a review from dalexsoto as a code owner July 1, 2025 22:07

dalexsoto approved these changes Jul 1, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Jul 2, 2025

View reviewed changes

Merge branch 'main' into dev/mandel/fix-appkit-managed-delegates

bd61a44

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/mandel/fix-appkit-managed-delegates

ab91f28

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/mandel/fix-appkit-managed-delegates

0105255

mandel-macaque merged commit 967b6f3 into main Jul 18, 2025
44 checks passed

mandel-macaque deleted the dev/mandel/fix-appkit-managed-delegates branch July 18, 2025 02:02

[AppKit] Fix Action based delegate signatures. #23246

[AppKit] Fix Action based delegate signatures. #23246

Uh oh!

Conversation

mandel-macaque commented Jul 1, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 16, 2025

✅ [CI Build #0105255] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 16, 2025

✅ [PR Build #0105255] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 16, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 16, 2025

✅ [CI Build #0105255] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 16, 2025

💻 [CI Build #0105255] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 16, 2025

💻 [CI Build #0105255] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 16, 2025

💻 [CI Build #0105255] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 16, 2025

💻 [CI Build #0105255] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 16, 2025

🚀 [CI Build #0105255] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

rolfbjarne Jul 2, 2025 •

edited

Loading