-
Notifications
You must be signed in to change notification settings - Fork 547
[msbuild] Don't warn about repeated files when looking for duplicated resources. #23250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… resources. When detecting duplicated resources, make sure to ignore repeated files, we only want to warn about duplicated resources when they come from different files. This fixes an issue where we'd warn about (and not add to the app) a resource if it was added more than once to the build.
✅ [CI Build #6d47aaf] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #6d47aaf] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #6d47aaf] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #6d47aaf] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #6d47aaf] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #6d47aaf] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #6d47aaf] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #6d47aaf] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
When detecting duplicated resources, make sure to ignore repeated files, we
only want to warn about duplicated resources when they come from different
files.
This fixes an issue where we'd warn about (and not add to the app) a resource
if it was added more than once to the build.