KEMBAR78
[NSAction] Unify code between platforms. by rolfbjarne · Pull Request #23309 · dotnet/macios · GitHub
Skip to content

[NSAction] Unify code between platforms. #23309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
+0 −12
Merged

[NSAction] Unify code between platforms. #23309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[NSAction] Unify code between platforms. 
Once upon a time, over a decade ago, Xamarin.iOS and Xamarin.Mac were
different in many ways, and a workaround was required for Xamarin.Mac.

This is no longer the case, all our platforms are very similar, so make the
code behave the same everywhere.
  • Loading branch information
@rolfbjarne
rolfbjarne committed Jul 11, 2025
commit 200f5312cc969d94e5cad5d55d38d1a41cae2018
12 changes: 0 additions & 12 deletions src/Foundation/NSAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,19 +118,7 @@ protected NSAsyncDispatcher ()
public override void Apply ()
{
gch.Free ();

//
// Although I would like to call Dispose here, to
// reduce the load on the GC, we have some useful diagnostic
// code in our runtime that is useful to track down
// problems, so we are removing the Dispose and letting
// the GC and our pipeline do their job.
//
#if MONOTOUCH
// MonoTouch has fixed the above problems, and we can call
// Dispose here.
Dispose ();
#endif
}
}

Expand Down
Loading