KEMBAR78
[Windows] _BeforeUnpackLibraryResources - Delete all files in a single run by emaf · Pull Request #23441 · dotnet/macios · GitHub
Skip to content

[Windows] _BeforeUnpackLibraryResources - Delete all files in a single run #23441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

[Windows] _BeforeUnpackLibraryResources - Delete all files in a single run #23441

merged 1 commit into from
Jul 31, 2025

Conversation

@emaf
Copy link
Contributor

@emaf emaf commented Jul 30, 2025

Minor perf improvement by executing delete once with all the files to delete instead of running it for each file.

image

Fixes #23440

@emaf
[Windows] _BeforeUnpackLibraryResources - Delete all files in a singl…
5d70ac1 
…e run

Minor perf improvement by executing delete once with all the files to delete instead of running it for each file.

Fixes #23440
@emaf emaf requested review from mauroa and rolfbjarne as code owners July 30, 2025 19:55
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #5d70ac1] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #5d70ac1] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #5d70ac1] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #5d70ac1] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #5d70ac1] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #5d70ac1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #5d70ac1] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #5d70ac1] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5d70ac15ddcc4f0ded97f0f0d697bb66eb73d593 [PR build]

@rolfbjarne rolfbjarne merged commit 27c56a6 into main Jul 31, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/ema/delete-perf branch July 31, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mauroa mauroa mauroa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Windows build perf] _BeforeUnpackLibraryResources runs Delete for each file

4 participants

@emaf @vs-mobiletools-engineering-service2 @rolfbjarne @mauroa