KEMBAR78
[runtime] Call mono_jit_cleanup upon exit. by rolfbjarne · Pull Request #23446 · dotnet/macios · GitHub
Skip to content

[runtime] Call mono_jit_cleanup upon exit. #23446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2025
Merged

[runtime] Call mono_jit_cleanup upon exit. #23446

merged 2 commits into from
Aug 4, 2025

Conversation

@rolfbjarne
Copy link
Member

Call mono_jit_cleanup upon exit, because profilers depend on this to flush
buffers, etc.

Also use mono_jit_init instead of mono_jit_init_version, because the
latter is deprecated.

Ref: dotnet/diagnostics#5529 (comment)

@rolfbjarne
[runtime] Call mono_jit_cleanup upon exit.
9037770 
Call `mono_jit_cleanup` upon exit, because profilers depend on this to flush
buffers, etc.

Also use `mono_jit_init` instead of `mono_jit_init_version`, because the
latter is deprecated.

Ref: dotnet/diagnostics#5529 (comment)
@rolfbjarne rolfbjarne mentioned this pull request Jul 31, 2025
Closed
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #c4f2212] Build passed (Build packages) ✅

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #c4f2212] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #c4f2212] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c4f2212] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c4f2212] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c4f2212] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c4f2212] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #c4f2212] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c4f2212f7a8888da0cc96241a7e98510b69a1134 [PR build]

@rolfbjarne rolfbjarne merged commit 311df45 into main Aug 4, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/mono-jit-init branch August 4, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto