[Windows] Skip running tasks with no inputs #23458

emaf · 2025-08-01T14:56:30Z

This is a very minor perf improvements that could help when building remotely from Windows with slow connections (i.e., from Devbox).

It skips running some tasks that not always have inputs to avoid the unnecessary network round tripping.

Fixes #19600

This is a very minor perf improvements that could help when building remotely from Windows with slow connections (i.e., from Devbox). It skips running some tasks that not always have inputs to avoid the unnecessary network round tripping.

msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Common.After.targets

vs-mobiletools-engineering-service2 · 2025-08-04T21:23:24Z

✅ [PR Build #664631a] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

vs-mobiletools-engineering-service2 · 2025-08-04T21:24:06Z

✅ [CI Build #664631a] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

vs-mobiletools-engineering-service2 · 2025-08-04T21:49:19Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

vs-mobiletools-engineering-service2 · 2025-08-04T22:18:18Z

✅ [CI Build #664631a] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

vs-mobiletools-engineering-service2 · 2025-08-04T22:29:01Z

💻 [CI Build #664631a] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

vs-mobiletools-engineering-service2 · 2025-08-04T22:29:50Z

💻 [CI Build #664631a] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

vs-mobiletools-engineering-service2 · 2025-08-04T22:31:39Z

💻 [CI Build #664631a] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

vs-mobiletools-engineering-service2 · 2025-08-04T22:31:58Z

💻 [CI Build #664631a] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

vs-mobiletools-engineering-service2 · 2025-08-05T00:09:41Z

🚀 [CI Build #664631a] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 664631a683f63a66e7e159bfa7cd004b0188d4d6 [PR build]

[Windows] Skip running tasks with no inputs

626bfba

This is a very minor perf improvements that could help when building remotely from Windows with slow connections (i.e., from Devbox). It skips running some tasks that not always have inputs to avoid the unnecessary network round tripping.

emaf requested review from mauroa and rolfbjarne as code owners August 1, 2025 14:56

rolfbjarne approved these changes Aug 1, 2025

View reviewed changes

msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Common.After.targets Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Add checks to tasks instead of targets

0f91d82

emaf force-pushed the dev/ema/perf-no-input branch from 15e55ed to 0f91d82 Compare August 1, 2025 17:03

GitHub Actions Autoformatter and others added 2 commits August 1, 2025 17:05

Auto-format source code

b69ff7e

Merge branch 'main' into dev/ema/perf-no-input

9e96e3b

This comment has been minimized.

Sign in to view

emaf requested a review from rolfbjarne August 1, 2025 18:56

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Aug 2, 2025

View reviewed changes

mandel-macaque approved these changes Aug 2, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne mentioned this pull request Aug 4, 2025

Skip calling certain Tasks if the input is empty #22689

Closed

Merge branch 'main' into dev/ema/perf-no-input

664631a

emaf enabled auto-merge August 4, 2025 20:57

emaf merged commit ca505ca into main Aug 5, 2025
44 checks passed

emaf deleted the dev/ema/perf-no-input branch August 5, 2025 00:10

[Windows] Skip running tasks with no inputs #23458

[Windows] Skip running tasks with no inputs #23458

Uh oh!

Conversation

emaf commented Aug 1, 2025

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 4, 2025

✅ [PR Build #664631a] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 4, 2025

✅ [CI Build #664631a] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 4, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 4, 2025

✅ [CI Build #664631a] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 4, 2025

💻 [CI Build #664631a] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 4, 2025

💻 [CI Build #664631a] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 4, 2025

💻 [CI Build #664631a] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 4, 2025

💻 [CI Build #664631a] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 5, 2025

🚀 [CI Build #664631a] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development