[Windows] Make LinkNativeCode create output file #23534
Conversation
The `_LinkNativeExecutable` always runs because its inputs/outputs are not created on Windows. Its own output file was never created because the task was not configured to do so. Also, the `_MtouchSymbolsList` was being written remotely so it was never found on Windows when checking the outputs. It's safe to write this locally as it will be copied as part of running this task as it is one of its declared dependencies. Fixes #19610
✅ [CI Build #b2ea1de] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #b2ea1de] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #b2ea1de] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #b2ea1de] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #b2ea1de] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #b2ea1de] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #b2ea1de] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
🚀 [CI Build #b2ea1de] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
4 participants
The
_LinkNativeExecutablealways runs because its inputs/outputs are not created on Windows. Its own output file was never created because the task was not configured to do so.Also, the
_MtouchSymbolsListwas being written remotely so it was never found on Windows when checking the outputs. It's safe to write this locally as it will be copied as part of running this task as it is one of its declared dependencies.For the target to be fully skipped this fix depends on #23533, which makes the compiled native executable output file to exist on Windows.
Fixes #19610