KEMBAR78
[Windows] Add inputs/outputs to _CreatePkgInfo by emaf · Pull Request #23553 · dotnet/macios · GitHub
Skip to content

[Windows] Add inputs/outputs to _CreatePkgInfo #23553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

[Windows] Add inputs/outputs to _CreatePkgInfo #23553

merged 2 commits into from
Aug 13, 2025

Conversation

emaf
Copy link
Contributor

@emaf emaf commented Aug 11, 2025

Makes the CreatePkgInfo task to produce an output file on Windows, and add the same as input of the _CreatePkgInfo target so if won't run again while the file exists as it is a static file.

This is a minor improvement but affects every single incremental build.

Fixes #19608.

@emaf
[Windows] Add inputs/outputs to _CreatePkgInfo
aabee1a 
Makes the `CreatePkgInfo` task to produce an output file on Windows, and add the same as input of the `_CreatePkgInfo` target so if won't run again while the file exists as it is a static file.

This is a minor improvement but affects every single incremental build.
@emaf emaf requested review from mauroa and rolfbjarne as code owners August 11, 2025 21:01
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@emaf emaf enabled auto-merge August 12, 2025 13:59
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@emaf emaf disabled auto-merge August 12, 2025 15:33
@emaf emaf enabled auto-merge (squash) August 12, 2025 15:34
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #d62e393] Build passed (Build packages) ✅

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #d62e393] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #d62e393] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d62e393] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d62e393] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d62e393] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d62e393] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #d62e393] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 128 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d62e393f2efbd5353e666987f034fca576818dfd [PR build]

@emaf emaf merged commit 3f82910 into main Aug 13, 2025
44 checks passed
@emaf emaf deleted the dev/ema/create-pkginfo branch August 13, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mauroa mauroa mauroa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Windows build perf] CreatePkgInfo is always executed

5 participants

@emaf @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @mauroa