[msbuild] Fix PartialAppManifests from library projects with incremental builds. #23865
Conversation
…tal builds.
1. Any PartialAppManifest items library projects are embedded into the library
as a resource.
2. Such resources are extracted from the library when referenced in an
executable project, and the PartialAppManifest item group (for the
executable project) is populated with these items.
3. The extraction target ("_UnpackLibraryResources") supports incremental
builds: it's only executed if the library didn't change since the last
build.
4. We still need to populate the PartialAppManifest item group even if the
extraction target didn't execute.
So implement support for storing the list of extracted PartialAppManifest
items to disk, and then reloading that list even if the extraction target
wasn't executed.
✅ [PR Build #f6fa9ff] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #f6fa9ff] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #f6fa9ff] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #f6fa9ff] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #f6fa9ff] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #f6fa9ff] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #f6fa9ff] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
💻 [CI Build #f6fa9ff] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #f6fa9ff] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
deleted the
dev/rolf/fix-incremental-partial-app-manifests
branch
4 participants
as a resource.
executable project, and the PartialAppManifest item group (for the
executable project) is populated with these items.
builds: it's only executed if the library didn't change since the last
build.
extraction target didn't execute.
So implement support for storing the list of extracted PartialAppManifest
items to disk, and then reloading that list even if the extraction target
wasn't executed.