-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows] Revert cleanup of AccessibilityExtensions
#31608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Revert cleanup of AccessibilityExtensions
#31608
Conversation
|
Hey there @@MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartyIX should this have a UITest part?
I added it intentionally to make sure that it works for customers (it's a bit surprising that there is no test that would catch it). The PR can be a simple revert and it would be OK as well. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs host code to run the test
Merge when that's added
0c01cf2 to
8b2496e
Compare
|
Added the test code. Please AZP for me to upload snapshots later. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8b2496e to
5742cf4
Compare
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-DeviceTests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/backport to release/9.0.1xx-sr11 |
|
Started backporting to release/9.0.1xx-sr11: https://github.com/dotnet/maui/actions/runs/17977802558 |
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Partial revert of #27052. This PR adds a test to make sure that any new PR does not introduce a similar regression.
Issues Fixed
Fixes #31606