Replace MessagingCenter in AlertManager #12910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Can we also add an interface and register it to the scoped container? Maybe something like
Or is that a separate PR? |
|
Ah I am doing this as I have no way to test currently |
This was referenced Jan 27, 2023
|
There are several unit tests failing, I think there are pending changes in the tests too. |
|
Yeah, I need to have a look as we can no longer just subscribe to some global messaging center. A tiny bit tricky, but I am sure we can fix it :) |
hartez
previously requested changes
Feb 10, 2023
samhouts
added
area-controls-dialog
platform/android
platform/ios
platform/tizen
mattleibow
force-pushed
the
dev/messenger
branch
from
7b7d5af to
4cece63
Compare
|
Stale, let's go with #27888 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Since the
MessagingCenterwas obsolete and now marked internal, we would love to remove it! Now it is happening!!!This PR starts that process by removing usages of the
MessagingCenterin theAlertManager.