KEMBAR78
RefreshviewHandler iOS by PureWeen · Pull Request #2029 · dotnet/maui · GitHub
Skip to content

Conversation

PureWeen
Copy link
Member

Description of Change

iOS RefreshViewHandler

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@PureWeen
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Base automatically changed from refreshview_handler to main August 18, 2021 22:05
@PureWeen
Copy link
Member Author

test failure unrelated
FontFamilyAndAttributesInitializesCorrectly

@rmarinho rmarinho merged commit 903c3fe into main Aug 19, 2021
@rmarinho rmarinho deleted the refreshview_handler_ios branch August 19, 2021 15:20
@samhouts samhouts added area-core-hosting Extensions / Hosting / AppBuilder / Startup area-navigation NavigationPage area-controls-refreshview RefreshView platform/ios labels Jul 11, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-refreshview RefreshView area-core-hosting Extensions / Hosting / AppBuilder / Startup area-navigation NavigationPage fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7! platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants