-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Android/iOS Button ImageSource #2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| namespace Microsoft.Maui | ||
| { | ||
| internal partial class ImageSourcePartWrapper<T> : IImageSourcePart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generalizes code for loading an image so that all code can benefit from cancel behavior and cases where the destination goes poof
d0fd5b2 to
6e80d38
Compare
932f4be to
f7e0b7a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
1a54b19 to
8e27926
Compare
8e27926 to
561311b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D:\agent\1\s\src\Controls\src\Core\HandlerImpl\Button\Button.Impl.cs(26,23): error CS1061: 'MauiButton' does not contain a definition for 'UpdateContentLayout' and no accessible extension method 'UpdateContentLayout' accepting a first argument of type 'MauiButton' could be found (are you missing a using directive or an assembly reference?) [D:\agent\1\s\src\Controls\src\Core\Controls.Core-net6.csproj]
5135c15 to
56abe61
Compare
Description of Change
Known Issues
Android still has some measuring issues that need to be worked through. The buttons with images on the start/end appear to have issues when nested inside a NavigationPage. We're going to replace the NavigationPage with a better
Maui.Coreimplementation so for now we will probably wait until that implementation is in to revisit the issues here. I did a quick test using the Android Navigation View handler branch and on that branch the layouts were all correct.Breaking Changes
This implementation breaks iOS but makes it match with Android so now the ContentLayout behavior between iOS and Android should be identical. The ultimate fix here would be to add some additional layout position options (LeftText, RightText, TopText, BottomText) . The implementation in XF on iOS is basically LeftText, RightText, TopText, BottomText.
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.