Fix for picker on hidden page opens after back navigation in Android #25319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only pop up when tapped or the Enter key is pressed.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
PureWeen
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Unfortunately, I don't think we'll be able to take this PR as is.
I wish on the PR you referenced we would have also applied this logic to Picker but since we didn't, this isn't really a behavior we can change right now especially if there isn't a replace API to open the picker from code.
My current thought here is
- We can keep this code how it currently is
- We try to add code so that if the user calls "Focus" directly then we have that trigger the opening of the picker.
@PureWeen, Thank you for the feedback. I understand the limitations here. I'll keep the current code as is and look into alternative solutions for this issue. |
|
/rebase |
sheiksyedm
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Mar 27, 2025
There was a problem hiding this comment.
The build is failing:
C:\a\_work\1\s\src\Controls\samples\Controls.Sample\Pages\UserInterface\VisualStatesPage.xaml(56,34): XamlC warning XC0022: Binding could be compiled to improve runtime performance if x:DataType is specified. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information. [C:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj::TargetFramework=net9.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(12,15): error CS0101: The namespace 'Maui.Controls.Sample.Issues' already contains a definition for 'MainPage' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-maccatalyst]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(14,10): error CS0111: Type 'MainPage' already defines a member called 'MainPage' with the same parameter types [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-maccatalyst]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(12,15): error CS0101: The namespace 'Maui.Controls.Sample.Issues' already contains a definition for 'MainPage' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-ios]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(14,10): error CS0111: Type 'MainPage' already defines a member called 'MainPage' with the same parameter types [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-ios]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(12,15): error CS0101: The namespace 'Maui.Controls.Sample.Issues' already contains a definition for 'MainPage' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-tizen]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(14,10): error CS0111: Type 'MainPage' already defines a member called 'MainPage' with the same parameter types [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-tizen]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(12,15): error CS0101: The namespace 'Maui.Controls.Sample.Issues' already contains a definition for 'MainPage' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-android]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(14,10): error CS0111: Type 'MainPage' already defines a member called 'MainPage' with the same parameter types [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-android]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(12,15): error CS0101: The namespace 'Maui.Controls.Sample.Issues' already contains a definition for 'MainPage' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(14,10): error CS0111: Type 'MainPage' already defines a member called 'MainPage' with the same parameter types [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(12,15): error CS0101: The namespace 'Maui.Controls.Sample.Issues' already contains a definition for 'MainPage' [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24862.cs(14,10): error CS0111: Type 'MainPage' already defines a member called 'MainPage' with the same parameter types [C:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
12 Error(s)
jsuarezruiz
requested changes
Mar 27, 2025
| } | ||
| } | ||
|
|
||
| public class MainPage : ContentPage |
There was a problem hiding this comment.
Rename to something like Issue24862MainPage.
|
Closing in favor of #29068 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The root cause of the issue is that the picker on MainPage unexpectedly opens the Picker dialog popup in FirstPage when navigating back, even though MainPage is not currently visible. This occurs because the Picker's focus changes during navigation back to FirstPage using Navigation.PopModalAsync(), triggering a click operation on the Picker, which opens the dialog regardless of MainPage's visibility.
Description of Issue Fix
The fix involves removing the auto-open behavior on focus from the Pickers by eliminating the FocusChanged event, which handled the Picker's OnClick operation when focus changed. This adjustment prevents the Picker dialog from opening during page navigation.
Specifically, when the Picker gains focus, the previous implementation would trigger PlatformView.CallOnClick() or OnClick(PlatformView, EventArgs.Empty), leading to the unwanted dialog popup. Additionally, the FocusableInTouchMode property is set to false to ensure that the Pickers do not gain focus unexpectedly.
Tested the behavior in the following platforms.
Issues Fixed
Fixes #24862
Reference
Similar code changes have been applied to the DatePicker and TimePicker dialogs to enable auto-opening after resolving the navigation issue. The link to the PR containing the changes is mentioned below.
#8913
Output
24862-BeforeFix.mp4
24862-AfterFix.mp4