[XC] Fix detection of x:DataType from outer scope #30083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the condition that detects when an x:DataType comes from an outer DataTemplate scope to eliminate spurious warnings.
- Simplified the
ifcheck by usingnameof(DataTemplate)and restricting the namespace toMauiUri. - Removed the incorrect global URI branch that previously caused all elements in the global namespace to be flagged.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jfversluis
approved these changes
Jun 20, 2025
StephaneDelcroix
approved these changes
Jun 20, 2025
|
Failing tests are unrelated |
PureWeen
deleted the
dev/srozsival/fix-xamlc-binding-datatype-in-outer-scope
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
XamlC reported the following warning for every single binding it compiled:
This was caused by an incorrect condition changed #29579. Since this is just a warning and not an error, it wasn't caught in code review.