Xmlns perf #30096
Merged
Xmlns perf #30096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes various parts of the Controls codebase by updating nullability annotations, improving method signatures, and addressing obsolete API usage while introducing performance‐related improvements for XML namespace processing. Key changes include:
- Updating type converter and binding method signatures to use nullable context (e.g. in ImageSourceConverter, GridLengthTypeConverter, FontSizeConverter).
- Converting several public API properties (such as those in DatePicker) from non‑nullable types to nullable, and adjusting internal remapping and event handling methods.
- Adding pragma directives to suppress obsolete API warnings in platform‑specific handlers.
Reviewed Changes
Copilot reviewed 291 out of 977 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/src/Core/DatePicker/DatePicker.cs | Changed Date, MinimumDate, and MaximumDate BindableProperties and public properties to use nullable DateTime. |
| src/Controls/src/Core/Element/Element.Mapper.cs | Introduced a static constructor that calls RemapIfNeeded to update element mappings. |
| src/Controls/src/Core/IExtendedTypeConverter.cs | Updated the ConvertFromInvariantString signature to return nullables. |
| src/Controls/src/Core/FontImageSource.cs | Added a ContentProperty attribute for the Glyph property. |
Comments suppressed due to low confidence (1)
src/Controls/src/Core/DatePicker/DatePicker.cs:20
- Changing the Date, MinimumDate, and MaximumDate properties from non-nullable DateTime to nullable DateTime? in DatePicker constitutes a breaking change in the public API. Please confirm that all consumers of these properties are updated to handle null values appropriately.
defaultValueCreator: (bindable) => DateTime.Today);
StephaneDelcroix
force-pushed
the
xmlnsPerf
branch
3 times, most recently
from
d7cbc0a to
b8a76b9
Compare
simonrozsival
approved these changes
Jun 20, 2025
jfversluis
approved these changes
Jun 20, 2025
StephaneDelcroix
force-pushed
the
xmlnsPerf
branch
from
b8a76b9 to
0d695ef
Compare
|
Failing tests are unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Issues Fixed
Fixes #