KEMBAR78
[.NET 10] Remove compatibility project from workloads by jsuarezruiz · Pull Request #30316 · dotnet/maui · GitHub
Skip to content

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Remove compatibility project from workloads.

Issues Fixed

Fixes #30207

@Copilot Copilot AI review requested due to automatic review settings June 30, 2025 08:46
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner June 30, 2025 08:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated compatibility project reference from Maui workloads to simplify the workload structure and reduce maintenance overhead.

  • Removed the reference to Microsoft.Maui.Controls.Compatibility from the README documentation
  • Eliminated the compatibility package entry from the workload manifest JSON
  • Deleted the compatibility package reference and related conditional logic from the bundled versions targets

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Workload/README.md Removed outdated compatibility project reference from the documentation
src/Workload/Microsoft.NET.Sdk.Maui.Manifest/WorkloadManifest.in.json Removed the compatibility package entry from the manifest
src/Workload/Microsoft.Maui.Sdk/Sdk/BundledVersions.in.targets Eliminated the compatibility package reference along with its associated comment block and conditional logic
Comments suppressed due to low confidence (3)

src/Workload/README.md:21

  • The removal of the compatibility reference from the documentation is appropriate; please verify that any associated documentation or release notes elsewhere have been updated accordingly.
* `Microsoft.Maui.Controls` - nuget

src/Workload/Microsoft.NET.Sdk.Maui.Manifest/WorkloadManifest.in.json:40

  • Ensure that the removal of the compatibility package from the manifest is clearly documented and that any references in broader documentation or tooling configurations are updated.
          "Microsoft.Maui.Controls.Xaml",

src/Workload/Microsoft.Maui.Sdk/Sdk/BundledVersions.in.targets:46

  • With the removal of the compatibility package reference, please ensure that relevant test cases in TestCases.HostApp and TestCases.Shared.Tests have been updated to cover this change and that the UI automation IDs remain unique.
    </_MauiImplicitPackageReference>

@PureWeen PureWeen merged commit 456b0db into net10.0 Jul 3, 2025
125 of 129 checks passed
@PureWeen PureWeen deleted the fix-30207 branch July 3, 2025 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2025
@PureWeen PureWeen added the area-compatibility Issues related to features in the Compatibility Nuget label Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-compatibility Issues related to features in the Compatibility Nuget t/housekeeping ♻︎

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants