[.NET 10] Implement auto-rotate images based on EXIF information & Preserve EXIF information for MediaPicker #30387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
p/0
|
🚨 API change(s) detected @davidortinau FYI |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for auto-rotating images based on EXIF orientation in MediaPicker by introducing a RotateImage option and integrating rotation processing across all platforms.
- Exposed a new
RotateImageproperty onMediaPickerOptionswith XML docs and updated PublicAPI. - Extended
ImageProcessorto handle EXIF rotation and wired it into each platform’s photo pick/capture flows. - Updated sample app ViewModel and XAML to allow toggling the new auto-rotate feature.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Essentials/src/PublicAPI/*/PublicAPI.Unshipped.txt | Added RotateImage.get/set to PublicAPI |
| src/Essentials/src/MediaPicker/MediaPicker.shared.cs | Defined RotateImage property and docs |
| src/Essentials/src/MediaPicker/MediaPicker.windows.cs | Injected rotation logic before compression |
| src/Essentials/src/MediaPicker/MediaPicker.ios.cs | Added rotation steps in picker result handling |
| src/Essentials/src/MediaPicker/MediaPicker.android.cs | Added rotation in capture and pick flows |
| src/Essentials/src/MediaPicker/ImageProcessor.*.cs | Implemented RotateImageAsync for each TFM |
| src/Essentials/samples/Samples/ViewModel/MediaPickerViewModel.cs | Added PickerRotateImage bindable property |
| src/Essentials/samples/Samples/View/MediaPickerPage.xaml | UI for toggling auto-rotate |
Comments suppressed due to low confidence (3)
src/Essentials/src/MediaPicker/MediaPicker.shared.cs:216
- The new
RotateImagefeature lacks automated tests. Please add unit tests inTestCases.Shared.Testsand corresponding UI tests inTestCases.HostAppto cover the auto-rotation behavior.
public bool RotateImage { get; set; } = false;
src/Essentials/src/MediaPicker/MediaPicker.windows.cs:100
- The call to
ProcessImageAsyncis missing the inputStreamargument (it currently only passes width, height, quality, filename, and rotate flag). You need to pass the source stream as the first parameter to match the method signature.
var processedStream = await ImageProcessor.ProcessImageAsync(
src/Essentials/src/MediaPicker/MediaPicker.android.cs:363
- Similar to Windows, the call to
ImageProcessor.ProcessImageAsynchere omits the required inputStreamargument. It needs the source stream as the first parameter before the width, height, quality, filename, and rotate flag.
options?.CompressionQuality ?? 100,
jsuarezruiz
requested changes
Jul 9, 2025
| } | ||
| catch (Exception ex) | ||
| { | ||
| System.Console.WriteLine($"Exception in RotateImageAsync: {ex}"); |
There was a problem hiding this comment.
Could we use ILogger here?
There was a problem hiding this comment.
Lets do this later as a bigger effort to do this everywhere the correct way
github-project-automation
bot
moved this from Ready To Review
to Changes Requested
in MAUI SDK Ongoing
jfversluis
force-pushed
the
net10-mediapicker-autorotate
branch
from
39ed162 to
5cc0e07
Compare
jfversluis
commented
Jul 18, 2025
rmarinho
reviewed
Jul 28, 2025
PureWeen
approved these changes
Jul 28, 2025
|
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
|
/backport to release/10.0.1xx-preview7 |
|
Started backporting to release/10.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/16580183038 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This implements the ability to auto-rotate images based on EXIF information for the MediaPicker in the Essentials library. In the
MediaPickerOptionsthere is a new propertyRotateImagethat can be set totrueto enable auto-rotation of images based on the EXIF information of the image, if available. If its set to false, it will return the image as-is.Additionally, the
PreserveMetaDataproperty has been added to control whether to preserve the metadata of the image when operations (rotate, resize, etc.) is being done on it.How to test
There are a couple of funny things in here if you look at the code. For iOS it will always seem to return UP and for Android I do setRotation(0) always. Which seems weird, but in fact its the right thing to do. This actually means that we will be using the orientation that is in the EXIF information.
The easiest way to functionally test this is to get a bunch of test images (use a search engine to find "EXIF test images"), load those on the device and start the sample app. This link will then be helpful to understand the different rotations: https://sirv.com/help/articles/rotate-photos-to-be-upright/
Issues Fixed
Fixes #29083