Revert "Fixed picker allows user input if the keyboard is visible" #30447
+2
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previous fix for preventing text input in Android Picker when the keyboard is visible and removes the associated UI tests for Issue24930.
- Revert OnKeyPress behavior adjustment in PickerManager.cs
- Remove shared and host-app UI tests for Issue24930
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/src/Platform/Android/PickerManager.cs | Restores original key handling by moving e.Handled assignments |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24930.cs | Removed shared UI test for picker input behavior |
| src/Controls/tests/TestCases.HostApp/Issues/Issue24930.cs | Removed host-app UI page for picker input test |
Comments suppressed due to low confidence (2)
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
jsuarezruiz
approved these changes
Jul 7, 2025
|
/rebase |
github-actions
bot
force-pushed
the
revert_26382
branch
from
47882c4 to
a4471e2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This behavior will be fixed on SR9 by the following PR #29068
Issues Fixed
Fixes #30430