[NET 10] Make public some APIs for StackNavigationManager on Android #30455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR exposes and refines navigation APIs on Android’s StackNavigationManager, allowing customization of fragment types and improving handler initialization.
- Exposed several internal navigation properties and methods in
PublicAPI.Unshipped.txt - Changed access modifiers on
StackNavigationManagermembers and addedSetNavigationViewFragmentType - Updated
NavigationViewHandlerto lazily initialize and enforce a singleStackNavigationManagerinstance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt | Added entries for new StackNavigationManager navigation APIs |
| src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs | Made navigation members protected, added _navigationViewFragmentType, SetNavigationViewFragmentType, and updated AddFragmentDestination |
| src/Core/src/Handlers/NavigationPage/NavigationViewHandler.Android.cs | Changed StackNavigationManager property to protected with setter, using lazy init and single-instance enforcement |
Comments suppressed due to low confidence (8)
src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs:226
- The new SetNavigationViewFragmentType method isn't covered by existing tests. Please add UI tests in TestCases.HostApp and TestCases.Shared.Tests to validate custom fragment type injection.
public void SetNavigationViewFragmentType(Type type)
src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs:226
- After introducing SetNavigationViewFragmentType and related public APIs, please update the XML documentation in the
/docs/folder to describe the new customization feature.
public void SetNavigationViewFragmentType(Type type)
src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs:36
- The NavHost property is declared as protected but is listed in PublicAPI.Unshipped.txt; consider making it public to match the exposed API surface.
protected NavHostFragment NavHost =>
src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs:39
- The NavController property is declared as protected but is listed in PublicAPI.Unshipped.txt; consider making it public to match the exposed API surface.
protected NavController NavController =>
src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs:42
- The FragmentNavigator property is declared as protected but is listed in PublicAPI.Unshipped.txt; consider making it public to match the exposed API surface.
protected FragmentNavigator FragmentNavigator =>
src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs:45
- The NavGraph property is declared as protected but is listed in PublicAPI.Unshipped.txt; consider making it public to match the exposed API surface.
protected NavGraph NavGraph => _navGraph ??
src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs:48
- The HasNavHost property is declared as protected but is listed in PublicAPI.Unshipped.txt; consider making it public to match the exposed API surface.
protected bool HasNavHost => _navHost is not null;
src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs:55
- The ToolbarElement property is declared as protected but is listed in PublicAPI.Unshipped.txt; consider making it public to match the exposed API surface.
protected IToolbarElement? ToolbarElement =>
PureWeen
reviewed
Jul 7, 2025
src/Core/src/Handlers/NavigationPage/NavigationViewHandler.Android.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jul 7, 2025
There was a problem hiding this comment.
There are a few more necessary pending changes:
C:\a\_work\1\s\src\Core\src\Handlers\Toolbar\ToolbarHandler.Android.cs(81,40): error CS0122: 'StackNavigationManager.NavGraph' is inaccessible due to its protection level [C:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net9.0-android35.0]
C:\a\_work\1\s\src\Core\src\Platform\Android\Navigation\NavigationViewFragment.cs(72,51): error CS0122: 'StackNavigationManager.HasNavHost' is inaccessible due to its protection level [C:\a\_work\1\s\src\Core\src\Core.csproj::TargetFramework=net9.0-android35.0]
2 Error(s)
github-project-automation
bot
moved this from Todo
to Changes Requested
in MAUI SDK Ongoing
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
navigation-handler-droid-net10
branch
from
0cb499f to
b5fc34f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously approved these changes
Jul 28, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
|
@pictos needs rebase on top of net10 please |
# Conflicts: # src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
PureWeen
force-pushed
the
navigation-handler-droid-net10
branch
from
b5fc34f to
ccc2888
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Jul 28, 2025
|
/backport to release/10.0.1xx-preview7 |
|
Started backporting to release/10.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/16578966943 |
jfversluis
approved these changes
Jul 29, 2025
github-project-automation
bot
moved this from Changes Requested
to Approved
in MAUI SDK Ongoing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This is building using net9, but the merge must happens on net10 branch
Issues Fixed
Fixes #30454